🐛 upgrade golangci-lint for go 1.18 support #1184

apricote · 2022-03-24T14:18:01Z

What this PR does / why we need it:

With versions lower than 1.45.0, golangci-lint returns a lot of invalid errors when running in Go 1.18+. Because of this, all PR pipeline jobs pull-cluster-api-provider-openstack-test fail.

This commit upgrades golangci-lint to the latest released version and fixes all linting errors that came up.

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

/hold

apricote · 2022-03-24T14:19:41Z

/cherry-pick release-0.5

tobiasgiese · 2022-03-24T15:45:47Z

/lgtm
/approve

thanks @apricote 👌🏻

seanschneeweiss

/lgtm
Thank you very much for fixing this.

seanschneeweiss · 2022-03-24T15:55:37Z

pkg/record/recorder.go

 // Event constructs an event from the given information and puts it in the queue for sending.
 func Event(object runtime.Object, reason, message string) {
-	defaultRecorder.Event(object, corev1.EventTypeNormal, strings.Title(reason), message)
+	defaultRecorder.Event(object, corev1.EventTypeNormal, cases.Title(language.Und).String(reason), message)


Out of curiosity, what is the language.Und doing?

same question here..

I think this is for Undefined language, it's not really explained in the [docs]. Using this language tag returned the expected result, as you can see in this Go Playground example: https://go.dev/play/p/fNew-KrewPY

Makes sense. Maybe change it to language.English then?

I think that makes sense, considering the reasons should be in english so all consumers of them can understand them.

k8s-triage-robot · 2022-03-24T18:04:44Z

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

tobiasgiese · 2022-03-24T18:32:38Z

/check-cla
/retest
/approve
/lgtm

I think prow had some issues today

k8s-ci-robot · 2022-03-24T18:33:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apricote, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tobiasgiese]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tobiasgiese · 2022-03-24T18:39:22Z

/cherry-pick release-0.5

k8s-infra-cherrypick-robot · 2022-03-24T18:39:23Z

@tobiasgiese: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jichenjc · 2022-03-25T03:11:37Z

/test pull-cluster-api-provider-openstack-test

jichenjc · 2022-03-25T03:13:39Z

@apricote guess you forgot to run go mod tidy to update go.sum?

jichenjc · 2022-03-25T03:13:58Z

api/v1alpha3/openstackcluster_types.go


 // OpenStackClusterSpec defines the desired state of OpenStackCluster.
 type OpenStackClusterSpec struct {
-


unrelated change..

These are changes that golangci-lint requested after I upgrade it. In this case the structs were not formatted with gofumpt

jichenjc · 2022-03-25T03:14:38Z

pkg/record/recorder.go

 // Event constructs an event from the given information and puts it in the queue for sending.
 func Event(object runtime.Object, reason, message string) {
-	defaultRecorder.Event(object, corev1.EventTypeNormal, strings.Title(reason), message)
+	defaultRecorder.Event(object, corev1.EventTypeNormal, cases.Title(language.Und).String(reason), message)


same question here..

netlify · 2022-03-25T08:15:07Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`e004f2b`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/623d9120b2024a00083f52f8
😎 Deploy Preview	https://deploy-preview-1184--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

apricote · 2022-03-25T08:15:31Z

@apricote guess you forgot to run go mod tidy to update go.sum?

Looks like I forgot to run it a second time after fixing the linting issues. New commit is up

With versions lower than 1.45.0, golangci-lint returns a lot of invalid errors when running in Go 1.18+. This commit upgrades golangci-lint to the latest released version and fixes all linting errors that came up.

apricote · 2022-03-25T11:33:54Z

/retest

chrischdi · 2022-03-25T13:07:04Z

/retest

chrischdi

/lgtm

mdbooth · 2022-03-25T14:08:50Z

/lgtm

pierreprinetti · 2022-03-25T14:12:57Z

pass! hurray!

apricote · 2022-03-25T14:51:56Z

/cherry-pick release-0.5

third time's a charm

apricote · 2022-04-14T09:21:57Z

/cherry-pick release-0.5

Third time also didn't work and I forgot about this afterwards, we are currently hitting this issue on #1204.

k8s-infra-cherrypick-robot · 2022-04-14T09:22:30Z

@apricote: #1184 failed to apply on top of branch "release-0.5":

Applying: upgrade golangci-lint for go 1.18 support
Using index info to reconstruct a base tree...
M	api/v1alpha3/openstackcluster_types.go
M	api/v1alpha4/openstackmachine_types.go
A	api/v1beta1/openstackmachine_types.go
M	go.mod
M	hack/tools/go.mod
M	hack/tools/go.sum
Falling back to patching base and 3-way merge...
Auto-merging hack/tools/go.sum
CONFLICT (content): Merge conflict in hack/tools/go.sum
Auto-merging hack/tools/go.mod
CONFLICT (content): Merge conflict in hack/tools/go.mod
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
CONFLICT (modify/delete): api/v1beta1/openstackmachine_types.go deleted in HEAD and modified in upgrade golangci-lint for go 1.18 support. Version upgrade golangci-lint for go 1.18 support of api/v1beta1/openstackmachine_types.go left in tree.
Auto-merging api/v1alpha4/openstackmachine_types.go
Auto-merging api/v1alpha3/openstackcluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 upgrade golangci-lint for go 1.18 support
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.5

Third time also didn't work and I forgot about this afterwards, we are currently hitting this issue on #1204.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Using strings.Title is deprecated in Go 1.18. This change is similar to kubernetes-sigs/cluster-api-provider-openstack#1184. Signed-off-by: Johanan Liebermann <[email protected]>

apricote mentioned this pull request Mar 24, 2022

🐛 Address CVE-2022-21698 #1182

Merged

3 tasks

seanschneeweiss reviewed Mar 24, 2022

View reviewed changes

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2022

k8s-ci-robot assigned tobiasgiese Mar 24, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022

jichenjc reviewed Mar 25, 2022

View reviewed changes

lentzi90 mentioned this pull request Mar 25, 2022

🏃 Enable controller tests #1183

Merged

3 tasks

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2022

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2022

upgrade golangci-lint for go 1.18 support

cae44b1

With versions lower than 1.45.0, golangci-lint returns a lot of invalid errors when running in Go 1.18+. This commit upgrades golangci-lint to the latest released version and fixes all linting errors that came up.

chrischdi reviewed Mar 25, 2022

View reviewed changes

k8s-ci-robot assigned chrischdi Mar 25, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2022

k8s-ci-robot merged commit b28f11f into kubernetes-sigs:main Mar 25, 2022

apricote deleted the fix-ci-go-18 branch March 25, 2022 14:34

apricote mentioned this pull request Apr 14, 2022

🐛 fix tests in release-0.5 #1208

Merged

johananl mentioned this pull request Sep 1, 2022

Fix Go lint errors for Go 1.18 kubernetes-sigs/cluster-api-provider-vsphere#1608

Closed


		// OpenStackClusterSpec defines the desired state of OpenStackCluster.
		type OpenStackClusterSpec struct {

🐛 upgrade golangci-lint for go 1.18 support #1184

🐛 upgrade golangci-lint for go 1.18 support #1184

Uh oh!

Conversation

apricote commented Mar 24, 2022

Uh oh!

apricote commented Mar 24, 2022

Uh oh!

tobiasgiese commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seanschneeweiss left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Mar 24, 2022

Uh oh!

tobiasgiese commented Mar 24, 2022

Uh oh!

k8s-ci-robot commented Mar 24, 2022

Uh oh!

tobiasgiese commented Mar 24, 2022

Uh oh!

k8s-infra-cherrypick-robot commented Mar 24, 2022

Uh oh!

jichenjc commented Mar 25, 2022

Uh oh!

jichenjc commented Mar 25, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

netlify bot commented Mar 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Uh oh!

apricote commented Mar 25, 2022

Uh oh!

apricote commented Mar 25, 2022

Uh oh!

chrischdi commented Mar 25, 2022

Uh oh!

chrischdi left a comment

Choose a reason for hiding this comment

Uh oh!

mdbooth commented Mar 25, 2022

Uh oh!

pierreprinetti commented Mar 25, 2022

Uh oh!

apricote commented Mar 25, 2022

Uh oh!

apricote commented Apr 14, 2022

Uh oh!

k8s-infra-cherrypick-robot commented Apr 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

tobiasgiese commented Mar 24, 2022 •

edited

Loading

netlify bot commented Mar 25, 2022 •

edited

Loading