Skip to content

Conversation

@noamran
Copy link
Contributor

@noamran noamran commented Dec 5, 2019

What this PR does / why we need it:
Renames the ErrorMessage and ErrorReason fields to FailureMessage and FailureReason in
GCPMachineStatus.

Which issue(s) this PR fixes :
Fixes #256

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @noamran. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2019
@detiber
Copy link
Contributor

detiber commented Dec 5, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2019
@vincepri
Copy link
Member

vincepri commented Dec 5, 2019

@noamran You can ignore the conformance failure for now, need to debug it today

@noamran noamran force-pushed the 256 branch 2 times, most recently from fa9748f to 882fecb Compare December 5, 2019 23:27
@vincepri
Copy link
Member

vincepri commented Dec 6, 2019

/test pull-cluster-api-provider-gcp-make-conformance

1 similar comment
@noamran
Copy link
Contributor Author

noamran commented Dec 6, 2019

/test pull-cluster-api-provider-gcp-make-conformance

@noamran noamran changed the title [WIP] Rename ErrorMessage and ErrorReason to FailureMessage and FailureReason Rename ErrorMessage and ErrorReason to FailureMessage and FailureReason Dec 7, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2019
@noamran noamran changed the title Rename ErrorMessage and ErrorReason to FailureMessage and FailureReason ⚠️Rename ErrorMessage and ErrorReason to FailureMessage and FailureReason Dec 7, 2019
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: noamran, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit e3369f0 into kubernetes-sigs:master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename ErrorMessage and ErrorReason to FailureMessage and FailureReason

4 participants