Skip to content

Save subnet details back to scope #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2021
Merged

Save subnet details back to scope #1401

merged 1 commit into from
Jun 3, 2021

Conversation

fiunchinho
Copy link
Contributor

@fiunchinho fiunchinho commented May 31, 2021 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

When SubnetSpec was changed to not be a pointer in #1144 we were not saving the Subnet details in the scope.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Save subnet details back to scope when reconciling already existing subnets

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 31, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @fiunchinho. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2021
@nader-ziada
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2021
@nader-ziada
Copy link
Contributor

the unit tests are failing on the lint because routetables_test.go is not gofmt-ed with -s (gofmt)

@fiunchinho fiunchinho force-pushed the fix-save-state-from-azure-api branch from 290e757 to 796639a Compare June 1, 2021 08:04
@fiunchinho
Copy link
Contributor Author

Fixed

nader-ziada
nader-ziada reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@nader-ziada nader-ziada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @fiunchinho

CecileRobertMichon
CecileRobertMichon reviewed Jun 1, 2021
View reviewed changes
azure/scope/managedcontrolplane.go Outdated
}
}

// SetSubnet sets the subnet spec for the subnet with the same role.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description isn't very accurate here

@CecileRobertMichon
Copy link
Contributor

Please add a release note, this is a user facing change

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 2, 2021
@fiunchinho
Copy link
Contributor Author

Done

@fiunchinho fiunchinho force-pushed the fix-save-state-from-azure-api branch 2 times, most recently from 7fedf7b to 1683074 Compare June 2, 2021 13:55
@nader-ziada
Copy link
Contributor

/retest

CecileRobertMichon
CecileRobertMichon reviewed Jun 2, 2021
View reviewed changes
@fiunchinho fiunchinho force-pushed the fix-save-state-from-azure-api branch from 88c1a67 to d1ce6c3 Compare June 3, 2021 10:48
@CecileRobertMichon
Copy link
Contributor

@fiunchinho please squash

lgtm

@fiunchinho
Save subnet details to scope
4cff58a 
Co-authored-by: Cecile Robert-Michon <[email protected]>
@fiunchinho fiunchinho force-pushed the fix-save-state-from-azure-api branch from d1ce6c3 to 4cff58a Compare June 3, 2021 17:45
@fiunchinho
Copy link
Contributor Author

Done

@k8s-ci-robot
Copy link
Contributor

@fiunchinho: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-provider-azure-apidiff 4cff58a link /test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit bdd9f8c into kubernetes-sigs:master Jun 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Jun 3, 2021
@fiunchinho fiunchinho deleted the fix-save-state-from-azure-api branch June 4, 2021 07:00
@fiunchinho fiunchinho mentioned this pull request Oct 9, 2023
Closed
9 tasks
willie-yao pushed a commit to willie-yao/cluster-api-provider-azure that referenced this pull request Jul 11, 2025
@aagusuab
KEDA v2.17.1 (kubernetes-sigs#1401)
075f650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devigned devigned Awaiting requested review from devigned

2 more reviewers

@nader-ziada nader-ziada nader-ziada left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@CecileRobertMichon CecileRobertMichon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@fiunchinho @k8s-ci-robot @nader-ziada @CecileRobertMichon