Mark all ID fields as READ-ONLY and standardize how we set resource IDs across services #1685
Description
/kind feature
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Currently, some of the services (subnets, route tables for example) set the Azure resource ID of existing resources in the spec as part of Reconcile(). There are a couple of problems with this:
- The ID field is part of the spec, not status, but is not user configurable. If a user were to set an ID, it would be overwritten by the controller. This field should not be in the spec or be clearly identified as read only.
- The implementation is inconsistent across the codebase, some resources have this while others don't. Furthermore, even when the ID is set, we don't use it most of the time, instead reconstructing the ID from scratch when needed (eg. route table ID in the subnet service).
- Modifying the spec mid reconcile can cause bugs if some of the previous fields are not respected, as seen in fix: don't create outbound LB if using NatGateway #1589
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
- cluster-api-provider-azure version:
- Kubernetes version: (use
kubectl version): - OS (e.g. from
/etc/os-release):