Skip to content

[E2E] Add check that the pod list is not empty. #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

[E2E] Add check that the pod list is not empty. #3841

merged 1 commit into from
Nov 15, 2022

Conversation

@Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Nov 10, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Adding a check that ensures that the pod list isn't empty. The for loop after it wouldn't error if there would be no pods.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Nov 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 10, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 10, 2022

/test ?

@k8s-ci-robot
Copy link
Contributor

@Skarlso: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 10, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member

@Skarlso tests are failing, could you PTAL?

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 11, 2022

Yeah I'll work on this today.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2022
@Skarlso Skarlso changed the title Add ensurance that pod list is not empty. [E2E] Add insurance that the pod list is not empty. Nov 11, 2022
@Skarlso Skarlso changed the title [E2E] Add insurance that the pod list is not empty. [E2E] Add check that the pod list is not empty. Nov 11, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 11, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 11, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 11, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 14, 2022

Interestingly enough for whatever reason, the coredns pod doesn't get an ip address.

 STEP: checking if pod ip address is ipv6 based: aws-node-x5594:2600:1f14:a9f:8a04:195f:dd40:db95:653a
STEP: checking if pod ip address is ipv6 based: coredns-657694c6f4-k78sp:

Luckily, the aws-node does, so... it's enough to check that one.

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 14, 2022

Oh of course, because I'm not waiting for them to have an IP address at all. 🤦

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 14, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 14, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@Skarlso Skarlso closed this Nov 14, 2022
@Skarlso Skarlso reopened this Nov 14, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 14, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 14, 2022 

STEP: checking if pods list is empty: 0

What in tarnation? OH!!! 🤦 The label selector is incorrect.

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 15, 2022

The label is now k8s-app=aws-node instead of app=aws-node. :D lovely. :D

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 15, 2022

/test pull-cluster-api-provider-aws-e2e-eks

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 15, 2022

Finally!!!!!!!!!!!!!!! :D

STEP: checking if pods list is empty: 1
STEP: checking if pod ip address is ipv6 based: aws-node-dngtq/2600:1f13:9b5:e004:981c:66d2:21f9:ef92
STEP: Deleting cluster eks-nodes-1c16wy
STEP: Waiting for cluster eks-nodes-1c16wy to be deleted
• [SLOW TEST:1496.124 seconds]

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 15, 2022

@richardcase If you so please. :D

@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2022
@richardcase
Copy link
Member

Nicely done @Skarlso , bravo 🎉

Let's wait for the e2e to pass, but it would be good to squash the changes....especially as they are for 1 file :)

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 15, 2022

Yep will do that once the tests pass :)))

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2022
@Ankitasw
Copy link
Member

New commit looks like rebased changes.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 15, 2022

/approve

as people seem to be happy with the changes :D

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit bc57291 into kubernetes-sigs:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dthorsen dthorsen Awaiting requested review from dthorsen

@sedefsavas sedefsavas Awaiting requested review from sedefsavas

Assignees

@Ankitasw Ankitasw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Skarlso @k8s-ci-robot @Ankitasw @richardcase