Downgrade K8s dependency version to v0.24 #3758
Conversation
k8s-ci-robot
added
kind/bug
|
cc @Skarlso |
| pflag.Parse() | ||
|
|
||
| if err := logsv1.ValidateAndApply(logOptions, nil); err != nil { | ||
| if err := logOptions.ValidateAndApply(nil); err != nil { |
There was a problem hiding this comment.
Is this right? I thought I made a mistake here and the fix was to use that logv1 package instead.
There was a problem hiding this comment.
Yes, logv1 package is in v0.25 and it was causing the bump to v0.25.
There was a problem hiding this comment.
When that line is not removed, go modules pull k8s.io v0.25, you can see this locally.
|
/cherry-pick release-2.0 |
|
@sedefsavas: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sedefsavas: new pull request created: #3759 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
/kind bug
What this PR does / why we need it:
Using k8s v0.25.x dependencies requires go version 1.19, this pr downgrades the k8s dependency versions to v0.24.2 which is same with CAPI v1.2.2.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: