Skip to content

Suspend and Resume ASG Processes #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2022
Merged

Suspend and Resume ASG Processes #3741

merged 3 commits into from
Oct 12, 2022

Conversation

@Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Sep 23, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3712

Suspend or Resume ASG processes.

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Sep 23, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 23, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Sep 23, 2022

Ops, forgot to add the conversion for to autoscaling group. 🤦

@Skarlso
Copy link
Contributor Author

Skarlso commented Sep 23, 2022 •
edited
Loading

Oh, this isn't easy at all... AutoScalingGroup is not a runtime object, so unmarshalling it doesn't work.

@Skarlso Skarlso force-pushed the suspend_asg_processes branch from 4dd3662 to 64caf16 Compare September 23, 2022 10:35
Skarlso
Skarlso commented Sep 23, 2022
View reviewed changes
@Skarlso Skarlso force-pushed the suspend_asg_processes branch 2 times, most recently from 1b40f27 to 79682e5 Compare September 23, 2022 11:10
richardcase
richardcase reviewed Sep 29, 2022
View reviewed changes
@Skarlso Skarlso force-pushed the suspend_asg_processes branch from 79682e5 to cb00528 Compare September 30, 2022 08:57
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2022
@Skarlso Skarlso force-pushed the suspend_asg_processes branch from cb00528 to 6811f71 Compare September 30, 2022 09:03
@Skarlso Skarlso requested review from richardcase and removed request for pydctw September 30, 2022 19:01
@Skarlso
Copy link
Contributor Author

Skarlso commented Oct 3, 2022

ping @Ankitasw as Richard is OOO. :))

richardcase
richardcase reviewed Oct 10, 2022
View reviewed changes
@Skarlso Skarlso requested a review from richardcase October 10, 2022 16:39
@richardcase
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member

e2e tests pass.

@Skarlso - would you be able to create a follow-up issue so that we update the e2e with a scenario where we disable and then re-enable a process?

From my side:

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Oct 11, 2022

Yeah sure no problem.

This was referenced Oct 11, 2022
Closed
Open
@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 91d6092 into kubernetes-sigs:main Oct 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auto Scaling Group Suspend Processes functionality

3 participants

@Skarlso @richardcase @k8s-ci-robot