Skip to content

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jan 9, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR installs latest blobfuse v1.1.1 according to https://github.com/Azure/azure-storage-fuse/wiki/1.-Installation#option-1---install-from-aptyum-package-repositories

Thus we don't need to rely on the blobfuse driver installed on the node. Thus this driver would work on Ubuntu 18.04.

Which issue(s) this PR fixes:

Fixes #74

Special notes for your reviewer:
And by using CMD ["/blobfuseplugin"], we could overwrite entry point by:

docker run -it -v /etc/kubernetes:/etc/kubernetes andyzhangx/blobfuse-csi:v0.4.0 /bin/bash

Release note:

feat: use standalone blobfuse driver

@andyzhangx andyzhangx requested a review from ZeroMagic January 9, 2020 07:41
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 9, 2020
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer January 9, 2020 07:41
revert Dockerfile change
@andyzhangx andyzhangx force-pushed the install-standalone-driver branch from 349d292 to a6e2bf8 Compare January 9, 2020 13:05
@chewong
Copy link
Member

chewong commented Jan 10, 2020

/retest

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, why we are adding pkg/blobfuseplugin/packages-microsoft-prod.deb to codes instead of downloading it?

@andyzhangx
Copy link
Member Author

By the way, why we are adding pkg/blobfuseplugin/packages-microsoft-prod.deb to codes instead of downloading it?

good idea, fixed

@andyzhangx andyzhangx merged commit cbf1f07 into kubernetes-sigs:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build blobfuse binary in Dockerfile
4 participants