Skip to content

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add getLatestAccountKey parameter in storage class

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: add getLatestAccountKey parameter in storage class

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cvvz and ZeroMagic June 14, 2023 02:39
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@andyzhangx andyzhangx merged commit b245c88 into kubernetes-sigs:master Jun 15, 2023
@andyzhangx
Copy link
Member Author

/cherrypick release-1.21

@k8s-infra-cherrypick-robot

@andyzhangx: #953 failed to apply on top of branch "release-1.21":

Applying: vendor: cloud provider lib upgrade
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/github.com/onsi/ginkgo/v2/CHANGELOG.md
M	vendor/github.com/onsi/ginkgo/v2/internal/suite.go
M	vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.go
M	vendor/github.com/onsi/ginkgo/v2/types/version.go
M	vendor/github.com/onsi/gomega/CHANGELOG.md
A	vendor/github.com/onsi/gomega/gcustom/make_matcher.go
M	vendor/github.com/onsi/gomega/gomega_dsl.go
A	vendor/golang.org/x/crypto/cryptobyte/asn1.go
M	vendor/golang.org/x/sys/unix/mkerrors.sh
M	vendor/golang.org/x/sys/unix/syscall_linux.go
M	vendor/golang.org/x/sys/unix/syscall_openbsd.go
M	vendor/golang.org/x/sys/unix/zsyscall_linux.go
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.go
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.s
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.go
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.s
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.go
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.s
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.go
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.s
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.go
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.s
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.go
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.s
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.go
M	vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.s
M	vendor/golang.org/x/sys/windows/zsyscall_windows.go
M	vendor/k8s.io/klog/v2/internal/serialize/keyvalues.go
M	vendor/k8s.io/klog/v2/k8s_references.go
M	vendor/k8s.io/klog/v2/klog.go
A	vendor/k8s.io/kube-openapi/pkg/handler/handler.go
M	vendor/modules.txt
M	vendor/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client.go
A	vendor/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/metrics/metrics.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/azureclients/loadbalancerclient/azure_loadbalancerclient.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/azureclients/loadbalancerclient/interface.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/azureclients/loadbalancerclient/mockloadbalancerclient/interface.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/consts/consts.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/consts/helpers.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/nodemanager/nodemanager.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_backoff.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_common.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_standard.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_vmss.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_vmssflex.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer_backendpool.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_managedDiskController.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_mock_loadbalancer_backendpool.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_mock_vmsets.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_privatelinkservice.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_standard.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_storageaccount.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_utils.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmsets.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmss.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmss_cache.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmssflex.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmssflex_cache.go
M	vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_wrap.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_wrap.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_wrap.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmssflex_cache.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmssflex.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmssflex.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmss_cache.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmss.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmss.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmsets.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_vmsets.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_utils.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_utils.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_storageaccount.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_standard.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_standard.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_privatelinkservice.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_mock_vmsets.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_mock_vmsets.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_mock_loadbalancer_backendpool.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_managedDiskController.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer_backendpool.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer_backendpool.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_loadbalancer.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_vmssflex.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_vmss.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_standard.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_common.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_backoff.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_backoff.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/nodemanager/nodemanager.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/consts/helpers.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/consts/consts.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/azureclients/loadbalancerclient/mockloadbalancerclient/interface.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/azureclients/loadbalancerclient/interface.go
Auto-merging vendor/sigs.k8s.io/cloud-provider-azure/pkg/azureclients/loadbalancerclient/azure_loadbalancerclient.go
CONFLICT (modify/delete): vendor/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/metrics/metrics.go deleted in HEAD and modified in vendor: cloud provider lib upgrade. Version vendor: cloud provider lib upgrade of vendor/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/metrics/metrics.go left in tree.
Auto-merging vendor/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client.go
CONFLICT (content): Merge conflict in vendor/sigs.k8s.io/apiserver-network-proxy/konnectivity-client/pkg/client/client.go
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
CONFLICT (modify/delete): vendor/k8s.io/kube-openapi/pkg/handler/handler.go deleted in HEAD and modified in vendor: cloud provider lib upgrade. Version vendor: cloud provider lib upgrade of vendor/k8s.io/kube-openapi/pkg/handler/handler.go left in tree.
Auto-merging vendor/k8s.io/klog/v2/klog.go
Auto-merging vendor/k8s.io/klog/v2/k8s_references.go
CONFLICT (content): Merge conflict in vendor/k8s.io/klog/v2/k8s_references.go
Auto-merging vendor/k8s.io/klog/v2/internal/serialize/keyvalues.go
CONFLICT (content): Merge conflict in vendor/k8s.io/klog/v2/internal/serialize/keyvalues.go
Auto-merging vendor/golang.org/x/sys/windows/zsyscall_windows.go
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.s
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.go
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.s
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.go
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.s
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.go
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.s
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.go
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.s
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.go
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.s
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.go
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.s
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.go
Auto-merging vendor/golang.org/x/sys/unix/zsyscall_linux.go
Auto-merging vendor/golang.org/x/sys/unix/syscall_openbsd.go
Auto-merging vendor/golang.org/x/sys/unix/syscall_linux.go
Auto-merging vendor/golang.org/x/sys/unix/mkerrors.sh
CONFLICT (modify/delete): vendor/golang.org/x/crypto/cryptobyte/asn1.go deleted in HEAD and modified in vendor: cloud provider lib upgrade. Version vendor: cloud provider lib upgrade of vendor/golang.org/x/crypto/cryptobyte/asn1.go left in tree.
Auto-merging vendor/github.com/onsi/gomega/gomega_dsl.go
CONFLICT (content): Merge conflict in vendor/github.com/onsi/gomega/gomega_dsl.go
CONFLICT (modify/delete): vendor/github.com/onsi/gomega/gcustom/make_matcher.go deleted in HEAD and modified in vendor: cloud provider lib upgrade. Version vendor: cloud provider lib upgrade of vendor/github.com/onsi/gomega/gcustom/make_matcher.go left in tree.
Auto-merging vendor/github.com/onsi/gomega/CHANGELOG.md
CONFLICT (content): Merge conflict in vendor/github.com/onsi/gomega/CHANGELOG.md
Auto-merging vendor/github.com/onsi/ginkgo/v2/types/version.go
CONFLICT (content): Merge conflict in vendor/github.com/onsi/ginkgo/v2/types/version.go
Auto-merging vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.go
Auto-merging vendor/github.com/onsi/ginkgo/v2/internal/suite.go
Auto-merging vendor/github.com/onsi/ginkgo/v2/CHANGELOG.md
CONFLICT (content): Merge conflict in vendor/github.com/onsi/ginkgo/v2/CHANGELOG.md
Removing vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2022-03-01/compute/communitygalleryimageversions.go
Removing vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2022-03-01/compute/communitygalleryimages.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 vendor: cloud provider lib upgrade
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

/cherrypick release-1.22

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #956

In response to this:

/cherrypick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants