Skip to content

fix: msi auth issue when secret is not provided #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

fix: msi auth issue when secret is not provided #927

merged 1 commit into from
May 12, 2023
+4 −0

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented May 12, 2023 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
There are 4 auth types: Key, SAS, MSI, SPN, and secret is only optional for MSI auth, this PR fixes the secret not found issue when secret is not provided for MSI auth, this bug was introduced by #867

Which issue(s) this PR fixes:

Fixes #926

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ZeroMagic and cvvz May 12, 2023 02:13
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2023
@andyzhangx andyzhangx mentioned this pull request May 12, 2023
Closed
@andyzhangx andyzhangx merged commit f7a4656 into kubernetes-sigs:master May 12, 2023
@andyzhangx
Copy link
Member Author

/cherry-pick release-1.21

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 12, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #928

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

/cherry-pick release-1.20

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 12, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #929

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cvvz cvvz Awaiting requested review from cvvz

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Secret required when using MSI auth for blob storage account with fuse protocol

3 participants

@andyzhangx @k8s-ci-robot @k8s-infra-cherrypick-robot