fix: support blobfuse2 install for GKE cos node #2125
Conversation
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
There was a problem hiding this comment.
Pull Request Overview
This PR fixes blobfuse2 installation support for Google Kubernetes Engine (GKE) Container-Optimized OS (COS) nodes by adding COS-specific handling to the installation scripts.
- Adds COS distribution detection and routing to the RHCOS installation script
- Configures COS-specific binary installation path (
/home/kubernetes/bin) - Fixes variable quoting issues in shell scripts for better robustness
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/blobfuse-proxy/install-proxy.sh | Fixes variable quoting for KUBELET_PATH |
| pkg/blobfuse-proxy/install-proxy-rhcos.sh | Adds COS support with configurable binary path and fixes variable quoting |
| pkg/blobfuse-proxy/init.sh | Routes COS distribution to use RHCOS installation script |
|
/retest |
|
/retest |
|
@andyzhangx Can we merge it to master? |
|
/cherrypick release-1.26 |
|
@andyzhangx: new pull request created: #2132 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| if [ -f "/host/${BIN_PATH}/blobfuse-proxy" ];then | ||
| old=$(sha256sum /host/${BIN_PATH}/blobfuse-proxy | awk '{print $1}') |
There was a problem hiding this comment.
bin path already contains /
this causes double / like: /host//home/kubernetes/bin/...
There was a problem hiding this comment.
that's ok, it should work on Linux, right?
There was a problem hiding this comment.
yeah, i tested it and that works, although it is ugly.
problem is that /host is not mounted on the init container, so none of the custom paths can work:
https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/charts/latest/blob-csi-driver/templates/csi-blob-node.yaml#L110
There was a problem hiding this comment.
we can mount /home/kubernetes/bin and /var/bin for cos and gardenlinux and introduce additional mounts for when a custom bin path is required, so that we don't expose the entire /host? wdyt @andyzhangx
5 participants
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: support blobfuse2 install for GKE cos node
on GKE cos node, we should set following mount option for blobfuse volume due to error
failed to create default work dir [mkdir /.blobfuse2: read-only file system]:Which issue(s) this PR fixes:
Fixes #2109, #1645, #2113
Requirements:
Special notes for your reviewer:
Release note: