Skip to content

[release-1.26] fix: grpc connection was not closed properly #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

[release-1.26] fix: grpc connection was not closed properly #1955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions pkg/blob/nodeserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,20 +165,29 @@ func (d *Driver) mountBlobfuseWithProxy(args, protocol string, authEnv []string)
defer cancel()
klog.V(2).Infof("start connecting to blobfuse proxy, protocol: %s, args: %s", protocol, args)
conn, err := grpc.DialContext(ctx, d.blobfuseProxyEndpoint, grpc.WithInsecure(), grpc.WithBlock())
if err == nil {
mountClient := NewMountClient(conn)
mountreq := mount_azure_blob.MountAzureBlobRequest{
MountArgs: args,
Protocol: protocol,
AuthEnv: authEnv,
}
klog.V(2).Infof("begin to mount with blobfuse proxy, protocol: %s, args: %s", protocol, args)
resp, err = mountClient.service.MountAzureBlob(context.TODO(), &mountreq)
if err != nil {
klog.Error("GRPC call returned with an error:", err)
if err != nil {
klog.Errorf("failed to connect to blobfuse proxy: %v", err)
return "", err
}
defer func() {
if err := conn.Close(); err != nil {
klog.Errorf("failed to close connection to blobfuse proxy: %v", err)
}
output = resp.GetOutput()
}()

mountClient := NewMountClient(conn)
mountreq := mount_azure_blob.MountAzureBlobRequest{
MountArgs: args,
Protocol: protocol,
AuthEnv: authEnv,
}
klog.V(2).Infof("begin to mount with blobfuse proxy, protocol: %s, args: %s", protocol, args)
resp, err = mountClient.service.MountAzureBlob(context.TODO(), &mountreq)
if err != nil {
klog.Error("GRPC call returned with an error:", err)
}
output = resp.GetOutput()

return output, err
}

Expand Down
Loading