Refactor: migrate blobclient to track2 sdk and fix ut cases

[MartinForReal]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Refactor: migrate blobclient to track2 sdk and fix ut cases

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:
gomock controller is not closed after ut test is complete. This may miss unexpected function call error.

Release note:

none

[MartinForReal]

/retest

[MartinForReal]

/retest

[andyzhangx]

@cvvz could you also take a look at this PR? thanks.

[andyzhangx]

all the 3 Azure CSI drivers supports empty cloud provider config, e.g.

blob-csi-driver/pkg/blob/azure.go

Lines 97 to 98 in 703d8dd

	if allowEmptyCloudConfig {
	klog.V(2).Infof("no cloud config provided, error: %v, driver will run without cloud config", err)

we need to make sure if there is no cloud provider config provided, this driver won't crash.

[MartinForReal]

If the cloud config is nil, the blob client is nil. How do we check volume capabilities in this scenario? @andyzhangx

[cvvz]

If the cloud config is nil, the blob client is nil. How do we check volume capabilities in this scenario? @andyzhangx

I believe k8s and sidecars actually never call ValidateVolumeCapabilities, although CSI spec requires CSI driver to implement it...

[andyzhangx]

If the cloud config is nil, the blob client is nil. How do we check volume capabilities in this scenario? @andyzhangx

I believe k8s and sidecars actually never call ValidateVolumeCapabilities, although CSI spec requires CSI driver to implement it...

If the cloud config is nil, then user should provide secrets(bring your own account key scenario), ValidateVolumeCapabilities would work well with secrets.

[cvvz]

If the cloud config is nil, then user should provide secrets(bring your own account key scenario), ValidateVolumeCapabilities would work well with secrets.

Yes, but it can be very easy to make csi driver crash (rather than throw error) once csi driver walk into the code that use d.cloud.BlobClient.

[andyzhangx]

If the cloud config is nil, then user should provide secrets(bring your own account key scenario), ValidateVolumeCapabilities would work well with secrets.

Yes, but it can be very easy to make csi driver crash (rather than throw error) once csi driver walk into the code that use d.cloud.BlobClient.

then we should check whether d.cloud.BlobClient is nil, if it's nil, then return error directly instead of crashing.

[MartinForReal]

/retest

[MartinForReal]

/retest

[andyzhangx]

If the cloud config is nil, then user should provide secrets(bring your own account key scenario), ValidateVolumeCapabilities would work well with secrets.

Yes, but it can be very easy to make csi driver crash (rather than throw error) once csi driver walk into the code that use d.cloud.BlobClient.

@cvvz could you take a look at this PR? any concern about blobclient issue?

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment