map access needs lock

[msau42]

All hostPathVolumes and hostPathSnapshots map updates/reads need a lock.

/help
/good-first-issue

[k8s-ci-robot]

@msau42:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

All hostPathVolumes and hostPathSnapshots map updates/reads need a lock.

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

/assign

[cwdsuzhou]

It seems I have sent a PR to fix the issue long long ago, but not anyone reviewed it.

#17

[cwdsuzhou]

If I should reopen it ?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[pohly]

/remove-lifecycle stale

All hostPathVolumes and hostPathSnapshots map updates/reads need a lock.

I think we need to go further than that: we also need to serialize gRPC calls unless it is certain that they can operate in parallel. A production CSI driver may want to serialize calls that operate on the same volume and then use locks on data structures that are shared between volumes. For hostpath I think it is sufficient to serialize all volume calls with a comment that explains that this is not necessarily how a production driver would do it.

When implemented like that, we don't need locks on those data structures.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale