-
Notifications
You must be signed in to change notification settings - Fork 564
chore: rev new version #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rev new version #2702
Conversation
cjihrig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I can not release a new version - there are multiple restrictions.
I've tried to circumvent 1. by temporary adding the branch in the allowed branches for the production environment - which kinda worked. My proposal: We change the script Otherwise we would need always manually release fixes for older versions. What do you think? Here are the runs btw: |
|
Any update here? I'm curious how previous versions 1.1 and 1.2 were released... EDIT: Ah, I see... They were released before 1.2, so probably from the |
|
Exactly! |
|
Yeah, we've never actually released a branched release, so yes, I think we do need to update the pre-check script. To clarify, there's an NPM token stored in the GH action so anyone with access to that action can perform a release. |
|
Do you have any updates here, please? I can see that it should now be possible to release older versions from the Thanks for your time. |
|
Tried it today but it seems like the npm token is expired. @brendandburns can you update the token? https://github.com/kubernetes-client/javascript/actions/runs/20072811449/job/57579276703 |
|
@mstruebing Not sure what type of token is used here but NPM tokens, but classic tokens are revoled from today https://github.blog/changelog/2025-12-09-npm-classic-tokens-revoked-session-based-auth-and-cli-token-management-now-available/ |
|
I'm not sure what kind of token was used but we need to have an access token that has access to the npm package in our CI. |
|
So I dug into this some more and it looks like there's a way to permanently trust the GitHub action on the npm side without requiring constant token renewal.
I will try to get this set up when I have a free moment.
…________________________________
From: Max Strübing ***@***.***>
Sent: Tuesday, December 9, 2025 10:28:55 PM
To: kubernetes-client/javascript ***@***.***>
Cc: brendanburns ***@***.***>; Mention ***@***.***>
Subject: Re: [kubernetes-client/javascript] chore: rev new version (PR #2702)
[https://avatars.githubusercontent.com/u/12071529?s=20&v=4]mstruebing left a comment (kubernetes-client/javascript#2702)<#2702 (comment)>
I'm not sure what kind of token was used but we need to have an access token that has access to the npm package in our CI.
As of now, as far as I know only @brendandburns<https://github.com/brendandburns> has access to the npm package and thus can maintain this token.
—
Reply to this email directly, view it on GitHub<#2702 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJZQXXJVJVBNVXCYQQJHDT4A64SPAVCNFSM6AAAAACNEQ24BGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMZVGU4TEOBWHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Ok, I set up the connection between our github action and npm, please try this again. |
|
@brendanburns the exact same issue is stated in the logs. I've run it round about 1 hour after you've announced the changes https://github.com/kubernetes-client/javascript/actions/runs/20111101932/job/57708322447 |
|
Update: I've deleted our Production Creating a new PR right now. https://github.com/kubernetes-client/javascript/actions/runs/20133131631/job/57779361806 |
|
Still the same issue, not sure what could be wrong otherwise. When clicking on the @brendanburns can you double check you've pasted the correct data into the npm connection? If I'm not mistaken it should be:
https://github.com/kubernetes-client/javascript/actions/runs/20133784506/job/57781582724 |
|
That looks correct though. |
|
There is one issue left, we need to define a tag as npm defined it this way and it can not be a semver version.
I've tried to do a couple of publishes in my test repo and it seems to work with a tag set: https://www.npmjs.com/package/@mstruebing/npm-publish-test?activeTab=versions I think we could still use Will bring up a PR. |
|
@dherbolt I have an early christmas present for you - 1.1.3 is on npm: https://www.npmjs.com/package/@kubernetes/client-node/v/1.1.3 |
|
@mstruebing |

Rev new version to be able to publish: #2701