chore: Some cleanup #1320
Merged
chore: Some cleanup #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
lgtm
|
@Ananya2001-an I think you need to rebase this to pick up a fix for the CI/CD. |
k8s-ci-robot
removed
the
lgtm
|
I see... the tests are failing for node version 20.8.0, weird haha |
mstruebing
approved these changes
Oct 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ananya2001-an, brendandburns, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
9 tasks
cjihrig
added a commit
to cjihrig/javascript
that referenced
this pull request
Sep 26, 2024
This method has been deprecated in Node.js. It looks like a similar change was made to the master branch as part of kubernetes-client#1320, but it was not cherry-picked to release-1.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some redundant code and also updated deprecated methods