-
Notifications
You must be signed in to change notification settings - Fork 2k
perf : unify the implement of isDuplicate in FIFODelta with client-go version #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NeverRaR The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @NeverRaR! |
/check-cla |
thanks for diving into it, the diff between java & golang informer here is introduced by #1259 for protecting potential memory leakage defensively. am not sure if the leakage is fixed yet, but it seems that merging two non-delete notifications will not bring any harm to the system, is it? |
if we choose merging two non-delete notifications,it will cause flake introduced in #1780 .Maybe ControllerTest should be further modified. |
/close b/c the flakiness is solved by #1793 |
@yue9944882: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Isduplicate in FIDODelta in Java client version is not consistent with the current implementation of client-go.


client-go implementation :
current java client implementation :