Skip to content

Kubernetes.Classic: add support for netstandard2.0 and net48 #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 3, 2022
Merged

Kubernetes.Classic: add support for netstandard2.0 and net48 #808

merged 8 commits into from
Apr 3, 2022

Conversation

@tg123
Copy link
Member

@tg123 tg123 commented Mar 24, 2022

fix #743

support basic API call for older .net runtime, watcher, exec etc. are not supported at the moment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tg123
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 24, 2022
@tg123
Copy link
Member Author

tg123 commented Mar 24, 2022

/hold

trying to run some basic ut

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@tg123 tg123 marked this pull request as draft March 29, 2022 20:00
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 29, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@tg123 tg123 marked this pull request as ready for review April 1, 2022 22:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2022
@tg123
Copy link
Member Author

tg123 commented Apr 1, 2022

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2022
@brendandburns
Copy link
Contributor

brendandburns commented Apr 3, 2022

\lgtm
\approve

@tg123
Copy link
Member Author

tg123 commented Apr 3, 2022

I am going to merge it as windows style \ is not recognized by bot

@tg123 tg123 merged commit 8575548 into kubernetes-client:master Apr 3, 2022
@zhiweiv zhiweiv mentioned this pull request Apr 19, 2022
Merged
@tg123 tg123 deleted the net48 branch April 19, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Framework no longer supported

3 participants

@tg123 @k8s-ci-robot @brendandburns