Add an initial generic client. #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
brendandburns
force-pushed
the
generic
branch
from
5062930 to
52fea5a
Compare
tg123
reviewed
Nov 20, 2020
|
|
||
| namespace k8s | ||
| { | ||
| public class GenericClient |
There was a problem hiding this comment.
Not sure what the suggestion is here, can you clarify?
There was a problem hiding this comment.
was talking about GenericClient<T>
but seems GenericClient is more generic
There was a problem hiding this comment.
recall
plural was in ctor, so I still think GenericClient<T> is better
brendandburns
force-pushed
the
generic
branch
from
52fea5a to
6d2900f
Compare
brendandburns
force-pushed
the
generic
branch
from
6d2900f to
660d80a
Compare
|
Comments mostly addressed, please take another look. |
tg123
approved these changes
Nov 23, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.