Skip to content

DelegatingHandler now works with Kubernetes clients #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2017

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Nov 7, 2017

this enables user side create a Kubernetes client with all kinds of generated ctors:

  • public Kubernetes(ServiceClientCredentials credentials, params DelegatingHandler[] handlers)
  • public Kubernetes(ServiceClientCredentials credentials, HttpClientHandler rootHandler, params DelegatingHandler[] handlers)
  • ...

watcher handler will be applied to them automatically. thus, user side will no long binded to KubernetesClientConfiguration ctor.

Also KubernetesClientConfiguration ctor is now support DelegatingHandler[]

var handler1 = new DummyHandler();
var handler2 = new DummyHandler();

var client = new Kubernetes(KubernetesClientConfiguration.BuildConfigFromConfigFile(), handler1, handler2);

This PR also remove a confusing ctor KubernetesClientConfiguration which was replace by factory style ctor BuildConfigFromConfigFile(string masterUrl = null, string kubeconfigPath = null)

@brendandburns
Copy link
Contributor

LGTM, but needs rebase.

@brendandburns brendandburns merged commit 92ddad2 into kubernetes-client:master Nov 14, 2017
@tg123 tg123 deleted the movector branch November 15, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants