Skip to content

Correct the content type in the Kubernetes client. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

brendandburns
Copy link
Contributor

This is a temporary fix, we need a fix in upstream swagger, AutoRest or post-processing.

@krabhishek8260
Copy link
Contributor

krabhishek8260 commented Sep 29, 2017

With this change too the library is still not usable for POST calls without fixing #9 .
If swagger codegen generated libraries are okay with the new post-processed Swagger, we can do that as of now.

@brendandburns
Copy link
Contributor Author

I did a kubernetes PR, so the code is there now:

https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json

We need to re-run AutoRest to regenerate.

@krabhishek8260
Copy link
Contributor

Great. I will try to rerun AutoRest and regenerate the client.
Thanks!

@krabhishek8260
Copy link
Contributor

The generator Docker image does not have autorest. I added autorest to the Dockerfile but I have not been able to successfully generate the client. I am talking to the autorest team to find out what's wrong.

@brendandburns brendandburns merged commit c108799 into kubernetes-client:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants