Skip to content

Conversation

@brendandburns
Copy link
Contributor

@brendandburns
Copy link
Contributor Author

@krabhishek8260 @colemickens any chance I can get a quick LGTM?

@colemickens
Copy link
Contributor

  1. I found it a bit weird that getDefaultConfiguration doesn't throw and instead the caller must check for null.

  2. It looks like it still won't handle the kubeconfig I posted in kubeconfig handling is overly sensitive #24, but instead will silently fall out without good credentials and avoid the NPE at least?

@brendandburns
Copy link
Contributor Author

closing this, it's out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants