Skip to content

Fix up versions and improve config loading... #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix up versions and improve config loading... #25

wants to merge 2 commits into from

Conversation

brendandburns
Copy link
Contributor

@brendandburns
Copy link
Contributor Author

@krabhishek8260 @colemickens any chance I can get a quick LGTM?

@colemickens
Copy link
Contributor

  1. I found it a bit weird that getDefaultConfiguration doesn't throw and instead the caller must check for null.

  2. It looks like it still won't handle the kubeconfig I posted in kubeconfig handling is overly sensitive #24, but instead will silently fall out without good credentials and avoid the NPE at least?

@tg123 tg123 mentioned this pull request Nov 11, 2017
Merged
@brendandburns
Copy link
Contributor Author

closing this, it's out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendandburns @colemickens @brendanburns