Skip to content

SlnGen instructions are potentially incomplete #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2024
Merged

SlnGen instructions are potentially incomplete #1530

merged 1 commit into from
Apr 15, 2024
+1 −1

Conversation

@tg123
Copy link
Member

@tg123 tg123 commented Feb 29, 2024

Fixes #1528

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@ce0f192). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1530   +/-   ##
=========================================
  Coverage          ?   61.46%           
=========================================
  Files             ?      103           
  Lines             ?     3065           
  Branches          ?      637           
=========================================
  Hits              ?     1884           
  Misses            ?     1181           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwkarg
Copy link
Contributor

rwkarg commented Mar 4, 2024

I can confirm that the new documented instructions work for me.

@tg123 tg123 force-pushed the tg123/issue1528 branch from 1966a86 to 7c11685 Compare April 6, 2024 06:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 6, 2024
@brendandburns
Copy link
Contributor

brendandburns commented Apr 15, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit de7ecf1 into kubernetes-client:master Apr 15, 2024
@tg123 tg123 deleted the tg123/issue1528 branch January 9, 2025 07:00
This was referenced Sep 17, 2025
Open
Open
Closed
Open
Closed
Open
@dependabot dependabot bot mentioned this pull request Oct 15, 2025
Merged
@dependabot dependabot bot mentioned this pull request Oct 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SlnGen instructions are potentially incomplete

5 participants

@tg123 @codecov-commenter @rwkarg @brendandburns @k8s-ci-robot