Convert from godep to gomod #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prachirp
commented
Apr 23, 2020
prachirp
commented
- Follow the suggestion for golangci-lint (Unable to install package golangci/golangci-lint#1037)
- Follow the suggestion for golangci-lint (golangci/golangci-lint#1037)
frankfarzan
suggested changes
Apr 28, 2020
There was a problem hiding this comment.
Thanks for this change. Please update the PR to reflect this is converting godep to gomod.
Also need to think about:
- Testing the go binaries not exercised by e2e tests.
typegencomes to mind. You should probably test it locally once. - Consider release workflows that build go.
|
Tested locally for make build-typegen & make package-typegen commands, and release-typegen & release-gatekeeper-function workflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.