Skip to content

chore(deps): bump storybook to 9.1.13 DEV-888 #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(deps): bump storybook to 9.1.13 DEV-888 #6080

wants to merge 1 commit into from

Conversation

@magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Aug 8, 2025 •
edited
Loading

🗒️ Checklist

  1. run linter locally
  2. update developer docs (API, README, inline, etc.), if any
  3. for user-facing doc changes create a Zulip thread at #Kobo support docs, if any
  4. draft PR with a title <type>(<scope>)<!>: <title> DEV-1234
  5. assign yourself, tag PR: at least Front end and/or Back end or workflow
  6. fill in the template below and delete template comments
  7. review thyself: read the diff and repro the preview as written
  8. open PR & confirm that CI passes & request reviewers, if needed
  9. delete this section before merging

💭 Notes

Updated storybook packages versions with their internal tool.

Also updated react-refresh and the other refresh package, as I thought it would fix a problem with @storybook/addon-webpack5-compiler-swc. It didn't. But the bump didn't break anything, so I left it there.

The TerserPlugin configuration in .storybook/main.js was crashing (npx) storybook build command. I've changed it a bit following some advice online. AFAIK it is not using swc now, but it is still helpful 🤷 The previous work here was 19e5a5f

Added @typescript-eslint/parser because eslint complained without it. My guess is that update to eslint-plugin-storybook escalated this requirement 🤷

👀 Preview steps

  1. npm install
  2. npm run storybook
  3. go to http://localhost:6006/
  4. 🟢 [on PR] notice that it still works

@magicznyleszek magicznyleszek self-assigned this Aug 8, 2025
@magicznyleszek magicznyleszek added dependencies Pull requests that update a dependency file Front end labels Aug 8, 2025
@magicznyleszek magicznyleszek changed the title chore(deps): bump storybook to 9.1.1 from 9.0.0-beta.11 (and all related) chore(deps): bump storybook from 9.0.0-beta.11 to 9.1.1 (and all related) Aug 8, 2025
@magicznyleszek magicznyleszek marked this pull request as ready for review August 8, 2025 10:01
@magicznyleszek magicznyleszek removed the request for review from p2edwards August 8, 2025 10:01
@magicznyleszek magicznyleszek removed the request for review from noliveleger August 8, 2025 10:03
@magicznyleszek magicznyleszek changed the title chore(deps): bump storybook from 9.0.0-beta.11 to 9.1.1 (and all related) chore(deps): bump storybook from 9.0.0-beta.11 to 9.1.1 (and all related) DEV-888 Aug 12, 2025
pauloamorimbr
pauloamorimbr reviewed Sep 18, 2025
View reviewed changes
Akuukis
Akuukis reviewed Sep 22, 2025
View reviewed changes
p2edwards
p2edwards reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@p2edwards p2edwards left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking at this locally. On my current setup, the refresh plugin doesn't work when using watch mode (npx storybook dev -p 6006), and there's an error in the browser console related to the dark mode plugin.

.github/workflows/biome.yml
Comment on lines +48 to +50
# ```
# Error: Cannot find module '@biomejs/cli-linux-x64/biome'
# ```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - maybe this bug? npm/cli#4828. Fixed, but not backported, in npm 11. (npm/cli#8184)

Another workaround would be to add this and other packages to our package.json optionalDependencies so they don't get removed again (like this commit odoo/o-spreadsheet@9042443)

(found via https://www.npmjs.com/package/napi-postinstall)

@magicznyleszek
Copy link
Member Author

As per discussion on standup, @Akuukis will take over this one together with @p2edwards :) Thanks!

@Akuukis
chore(deps): bump storybook to 9.1.13 DEV-888
c41e8f2 
Squashed commit of the following:

commit 8835a10
Merge: 425c33a 3a1c852
Author: Leszek Pietrzak <[email protected]>
Date:   Mon Sep 22 16:03:21 2025 +0100

    Merge branch 'main' into leszek/bump-storybook-version

commit 425c33a
Author: Leszek <[email protected]>
Date:   Mon Sep 22 16:55:21 2025 +0200

    fix types in usage query

commit b6cab6e
Author: Leszek <[email protected]>
Date:   Mon Sep 22 14:34:35 2025 +0200

    try bumping tsconfig lib to es2022

commit 2b6a8ec
Author: Leszek <[email protected]>
Date:   Mon Sep 22 14:28:01 2025 +0200

    npm update rebuilt msw-mocks file :+1:

commit 29a0019
Author: Leszek <[email protected]>
Date:   Mon Sep 22 14:27:44 2025 +0200

    biome ignore package.json

commit a03e266
Author: Leszek <[email protected]>
Date:   Mon Sep 22 13:56:56 2025 +0200

    delete unneeded patch

commit 595bee4
Author: Leszek <[email protected]>
Date:   Mon Sep 22 13:47:39 2025 +0200

    rebuild package-lock with "npm update"

commit bd02dcc
Author: Leszek <[email protected]>
Date:   Mon Sep 22 13:40:19 2025 +0200

    run biome

commit a056520
Author: Leszek <[email protected]>
Date:   Mon Sep 22 10:51:22 2025 +0200

    biome fixes

commit e388567
Author: Leszek <[email protected]>
Date:   Mon Sep 22 10:49:24 2025 +0200

    biome missing dep hack

commit 0e67d73
Merge: 7d4d222 db47424
Author: Leszek Pietrzak <[email protected]>
Date:   Fri Sep 19 11:57:22 2025 +0100

    Merge branch 'main' into leszek/bump-storybook-version

commit 7d4d222
Merge: 60170b6 1cdd31f
Author: Leszek <[email protected]>
Date:   Wed Sep 17 22:39:43 2025 +0200

    Merge branch 'main' into leszek/bump-storybook-version

commit 60170b6
Merge: fa60e3f 3ca8946
Author: Leszek Pietrzak <[email protected]>
Date:   Mon Aug 18 10:16:57 2025 +0200

    Merge branch 'main' into leszek/bump-storybook-version

commit fa60e3f
Merge: f779d34 e2d3329
Author: Leszek Pietrzak <[email protected]>
Date:   Thu Aug 14 10:59:26 2025 +0200

    Merge branch 'main' into leszek/bump-storybook-version

commit f779d34
Author: Leszek <[email protected]>
Date:   Tue Aug 12 20:41:45 2025 +0200

    add @typescript-eslint/parser

commit bcf2565
Author: Leszek <[email protected]>
Date:   Tue Aug 12 20:04:29 2025 +0200

    add missing @storybook/types

commit 11b9748
Author: Leszek <[email protected]>
Date:   Tue Aug 12 19:15:11 2025 +0200

    remove old comment, bump versions again, chane terserplugin setup

commit 38ddb86
Merge: 0cd36cb 9c7f6ec
Author: Leszek Pietrzak <[email protected]>
Date:   Tue Aug 12 17:52:39 2025 +0200

    Merge branch 'main' into leszek/bump-storybook-version

commit 0cd36cb
Merge: 43d9254 7d2dd72
Author: Leszek Pietrzak <[email protected]>
Date:   Mon Aug 11 17:27:57 2025 +0200

    Merge branch 'main' into leszek/bump-storybook-version

commit 43d9254
Merge: 5c4843f 23f7f34
Author: Leszek Pietrzak <[email protected]>
Date:   Mon Aug 11 11:50:16 2025 +0200

    Merge branch 'main' into leszek/bump-storybook-version

commit 5c4843f
Merge: 687d527 47bc86f
Author: Leszek Pietrzak <[email protected]>
Date:   Mon Aug 11 11:21:49 2025 +0200

    Merge branch 'main' into leszek/bump-storybook-version

commit 687d527
Author: Leszek <[email protected]>
Date:   Fri Aug 8 12:09:01 2025 +0200

    add missing package

commit ec6473d
Merge: 83c7394 5b407ec
Author: Leszek <[email protected]>
Date:   Fri Aug 8 12:02:13 2025 +0200

    Merge branch 'main' into leszek/bump-storybook-version

commit 83c7394
Author: Leszek <[email protected]>
Date:   Fri Aug 8 11:52:18 2025 +0200

    bump storybook version(s)
@Akuukis Akuukis changed the title chore(deps): bump storybook from 9.0.0-beta.11 to 9.1.1 (and all related) DEV-888 chore(deps): bump storybook to 9.1.13 DEV-888 Oct 22, 2025
@Akuukis Akuukis force-pushed the leszek/bump-storybook-version branch from 8835a10 to c41e8f2 Compare October 22, 2025 13:05
@Akuukis Akuukis marked this pull request as draft October 22, 2025 13:05
@Akuukis
Copy link
Contributor

Akuukis commented Oct 22, 2025

Depends on (at least) bumping react-router first, let's put back to a draft this PR in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p2edwards p2edwards p2edwards left review comments

@Akuukis Akuukis Akuukis left review comments

@olive-KTB olive-KTB Awaiting requested review from olive-KTB olive-KTB is a code owner

@jnm jnm Awaiting requested review from jnm jnm is a code owner

@jamesrkiger jamesrkiger Awaiting requested review from jamesrkiger

@pauloamorimbr pauloamorimbr Awaiting requested review from pauloamorimbr

@noliveleger noliveleger Awaiting requested review from noliveleger noliveleger will be requested when the pull request is marked ready for review noliveleger is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Akuukis Akuukis

Labels

dependencies Pull requests that update a dependency file Front end

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magicznyleszek @Akuukis @p2edwards @pauloamorimbr