Skip to content

Prefer const #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianmhunt merged 3 commits into from
Dec 22, 2025
Merged

Prefer const #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
922bd58
eslint) apply prefer-const autofixes
phillipc Dec 22, 2025
f09b87d
Merge branch 'knockout:main' into prefer_const
phillipc Dec 22, 2025
1ef718e
fix) prettier
phillipc Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/bind/spec/asyncBindingBehaviors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('Deferred bindings', function () {
testNode = jasmine.prepareTestNode()
useMockForTasks(options)
options.deferUpdates = true
let provider = new DataBindProvider()
const provider = new DataBindProvider()
options.bindingProviderInstance = provider
bindingHandlers = provider.bindingHandlers
bindingHandlers.set(coreBindings)
Expand All @@ -48,7 +48,7 @@ describe('Deferred bindings', function () {
})

it('Should update bindings asynchronously', function () {
let observable = Observable('A')
const observable = Observable('A')

// The initial "applyBindings" is synchronous
testNode.innerHTML = "<div data-bind='test: myObservable'></div>"
Expand All @@ -73,7 +73,7 @@ describe('Deferred bindings', function () {
})

it('Should update templates asynchronously', function () {
let observable = Observable('A')
const observable = Observable('A')

testNode.innerHTML = "<div data-bind='template: {data: myObservable}'><div data-bind='test: $data'></div></div>"
applyBindings({ myObservable: observable }, testNode)
Expand All @@ -100,7 +100,7 @@ describe('Deferred bindings', function () {
})

it("Should update 'foreach' items asynchronously", function () {
let observable = ObservableArray(['A'])
const observable = ObservableArray(['A'])

testNode.innerHTML = "<div data-bind='foreach: {data: myObservables}'><div data-bind='test: $data'></div></div>"
applyBindings({ myObservables: observable }, testNode)
Expand Down Expand Up @@ -131,7 +131,7 @@ describe('Deferred bindings', function () {
observable.remove('A')
observable.push('A')

let nodeA = testNode.childNodes[0].childNodes[0],
const nodeA = testNode.childNodes[0].childNodes[0],
nodeB = testNode.childNodes[0].childNodes[1]
jasmine.Clock.tick(1)
expect(bindingSpy).not.toHaveBeenCalled()
Expand All @@ -144,7 +144,7 @@ describe('Deferred bindings', function () {
// is dragged and dropped in the same list, it must be deleted and re-added instead of being moved.

testNode.innerHTML = "<div data-bind='foreach: someItems'><span data-bind='text: childProp'></span></div>"
let someItems = ObservableArray([
const someItems = ObservableArray([
{ childProp: 'first child' },
{ childProp: 'second child' },
{ childProp: 'moving child' }
Expand All @@ -154,7 +154,7 @@ describe('Deferred bindings', function () {
'<span data-bind="text: childprop">first child</span><span data-bind="text: childprop">second child</span><span data-bind="text: childprop">moving child</span>'
)

let sourceIndex = 2,
const sourceIndex = 2,
targetIndex = 0,
itemNode = testNode.childNodes[0].childNodes[sourceIndex],
item = someItems()[sourceIndex]
Expand All @@ -175,7 +175,7 @@ describe('Deferred bindings', function () {
it('Should get latest value when conditionally included', function () {
// Test is based on example in https://github.com/knockout/knockout/issues/1975
testNode.innerHTML = '<div data-bind="if: show"><div data-bind="text: status"></div></div>'
let value = Observable(0),
const value = Observable(0),
is1 = pureComputed(function () {
return value() === 1
}),
Expand Down Expand Up @@ -252,9 +252,9 @@ describe('Deferred bindings', function () {
})

it('Should leave descendant nodes unchanged if the value is truthy and remains truthy when changed', function () {
let someItem = Observable(true)
const someItem = Observable(true)
testNode.innerHTML = "<div data-bind='if: someItem'><span data-bind='text: (++counter)'></span></div>"
let originalNode = testNode.childNodes[0].childNodes[0]
const originalNode = testNode.childNodes[0].childNodes[0]

// Value is initially true, so nodes are retained
applyBindings({ someItem: someItem, counter: 0 }, testNode)
Expand Down
40 changes: 20 additions & 20 deletions packages/bind/spec/bindingAttributeBehaviors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('Binding attribute syntax', function () {

beforeEach(function () {
// Set up the default binding handlers.
let provider = new MultiProvider({ providers: [new VirtualProvider(), new DataBindProvider()] })
const provider = new MultiProvider({ providers: [new VirtualProvider(), new DataBindProvider()] })
options.bindingProviderInstance = provider
bindingHandlers = provider.bindingHandlers
bindingHandlers.set(coreBindings)
Expand Down Expand Up @@ -71,7 +71,7 @@ describe('Binding attribute syntax', function () {
}) // Just to avoid interfering with other specs

let didInit = false
let suppliedViewModel = {}
const suppliedViewModel = {}
bindingHandlers.test = {
init: function (element, valueAccessor, allBindings, viewModel) {
expect(element.id).toEqual('testElement')
Expand All @@ -86,7 +86,7 @@ describe('Binding attribute syntax', function () {

it('applyBindings should accept two parameters and then act on second param as DOM node with first param as model', function () {
let didInit = false
let suppliedViewModel = {}
const suppliedViewModel = {}
bindingHandlers.test = {
init: function (element, valueAccessor, allBindings, viewModel) {
expect(element.id).toEqual('testElement')
Expand All @@ -96,7 +96,7 @@ describe('Binding attribute syntax', function () {
}
testNode.innerHTML = "<div id='testElement' data-bind='test'></div>"

let shouldNotMatchNode = document.createElement('DIV')
const shouldNotMatchNode = document.createElement('DIV')
shouldNotMatchNode.innerHTML = "<div id='shouldNotMatchThisElement' data-bind='test'></div>"
document.body.appendChild(shouldNotMatchNode)
this.after(function () {
Expand Down Expand Up @@ -287,7 +287,7 @@ describe('Binding attribute syntax', function () {

it('Calls options.onError, if it is defined', function () {
let oe_calls = 0
let oxy = koObservable()
const oxy = koObservable()
this.after(function () {
options.set('onError', undefined)
})
Expand All @@ -314,7 +314,7 @@ describe('Binding attribute syntax', function () {
})

it("Should invoke registered handlers's init() then update() methods passing binding data", function () {
let methodsInvoked = new Array()
const methodsInvoked = new Array()
bindingHandlers.test = {
init: function (element, valueAccessor, allBindings) {
methodsInvoked.push('init')
Expand All @@ -337,7 +337,7 @@ describe('Binding attribute syntax', function () {
})

it("Should invoke each handlers's init() and update() before running the next one", function () {
let methodsInvoked = new Array()
const methodsInvoked = new Array()
bindingHandlers.test1 = bindingHandlers.test2 = {
init: function (element, valueAccessor) {
methodsInvoked.push('init' + valueAccessor())
Expand Down Expand Up @@ -404,8 +404,8 @@ describe('Binding attribute syntax', function () {
it('Should use properties on the view model in preference to properties on the binding context', function () {
// In KO 3.5 this test relied on a bit of duck-typing (it has a $data).
testNode.innerHTML = "<div data-bind='text: $data.someProp'></div>"
let outer = new bindingContext({ someProp: 'Outer value' })
let inner = new bindingContext({ someProp: 'Inner value' }, outer)
const outer = new bindingContext({ someProp: 'Outer value' })
const inner = new bindingContext({ someProp: 'Inner value' }, outer)
applyBindings(inner, testNode)
expect(testNode).toContainText('Inner value')
})
Expand All @@ -419,7 +419,7 @@ describe('Binding attribute syntax', function () {
}
testNode.innerHTML =
"<div data-bind='with: sub'>Static<div data-bind='addCustomProperty: true'>Text-<div data-bind='text: $customProp'></div></div></div>"
let vm = { sub: {} }
const vm = { sub: {} }
applyBindings(vm, testNode)
expect(testNode).toContainText('StaticText-MyValue')
expect(contextFor(testNode.childNodes[0].childNodes[1].childNodes[1]).$customProp).toEqual('MyValue')
Expand Down Expand Up @@ -447,7 +447,7 @@ describe('Binding attribute syntax', function () {
testNode.innerHTML = "<div data-bind='with: $data'><div></div></div>"
applyBindings({}, testNode)

let allowedProperties = ['$parents', '$root', 'ko', '$rawData', '$data', '$parentContext', '$parent']
const allowedProperties = ['$parents', '$root', 'ko', '$rawData', '$data', '$parentContext', '$parent']
if (typeof Symbol('') !== 'symbol') {
// Test for shim
allowedProperties.push('_subscribable')
Expand Down Expand Up @@ -486,11 +486,11 @@ describe('Binding attribute syntax', function () {
bindingHandlers.allowBindings = {
init: function (elem, valueAccessor) {
// Let bindings proceed as normal *only if* my value is false
let shouldAllowBindings = unwrap(valueAccessor())
const shouldAllowBindings = unwrap(valueAccessor())
return { controlsDescendantBindings: !shouldAllowBindings }
}
}
let vm = { isVisible: true }
const vm = { isVisible: true }
applyBindings(vm, testNode)

// All of the bound nodes return the viewmodel
Expand All @@ -508,13 +508,13 @@ describe('Binding attribute syntax', function () {
// See https://github.com/knockout/knockout/issues/231#issuecomment-388210267
testNode.innerHTML = '<div data-bind="text: name"></div>'

let vm1 = { name: 'specific' }
const vm1 = { name: 'specific' }
applyBindingsToNode(testNode.childNodes[0], { text: vm1.name }, vm1)
expect(testNode).toContainText(vm1.name)
expect(dataFor(testNode.childNodes[0])).toBe(vm1)
expect(contextFor(testNode.childNodes[0]).$data).toBe(vm1)

let vm2 = { name: 'general' }
const vm2 = { name: 'general' }
applyBindings(vm2, testNode)
expect(testNode).toContainText(vm2.name)
expect(dataFor(testNode.childNodes[0])).toBe(vm2)
Expand Down Expand Up @@ -669,7 +669,7 @@ describe('Binding attribute syntax', function () {
it('Should be able to set and access correct context in custom containerless binding', function () {
bindingHandlers.bindChildrenWithCustomContext = {
init: function (element, valueAccessor, allBindings, viewModel, bindingContext) {
let innerContext = bindingContext.createChildContext({ myCustomData: 123 })
const innerContext = bindingContext.createChildContext({ myCustomData: 123 })
applyBindingsToDescendants(innerContext, element)
return { controlsDescendantBindings: true }
}
Expand All @@ -686,7 +686,7 @@ describe('Binding attribute syntax', function () {
delete bindingHandlers.nonexistentHandler
bindingHandlers.bindChildrenWithCustomContext = {
init: function (element, valueAccessor, allBindings, viewModel, bindingContext) {
let innerContext = bindingContext.createChildContext({ myCustomData: 123 })
const innerContext = bindingContext.createChildContext({ myCustomData: 123 })
applyBindingsToDescendants(innerContext, element)
return { controlsDescendantBindings: true }
}
Expand All @@ -703,7 +703,7 @@ describe('Binding attribute syntax', function () {
it('Should be able to access custom context variables in child context', function () {
bindingHandlers.bindChildrenWithCustomContext = {
init: function (element, valueAccessor, allBindings, viewModel, bindingContext) {
let innerContext = bindingContext.createChildContext({ myCustomData: 123 })
const innerContext = bindingContext.createChildContext({ myCustomData: 123 })
innerContext.customValue = 'xyz'
applyBindingsToDescendants(innerContext, element)
return { controlsDescendantBindings: true }
Expand Down Expand Up @@ -824,7 +824,7 @@ describe('Binding attribute syntax', function () {
// First replace the binding provider with one that's hardcoded to replace all text
// content with a special message, via a binding handler that operates on text nodes

let originalBindingProvider = options.bindingProviderInstance
const originalBindingProvider = options.bindingProviderInstance
class TestProvider extends Provider {
override get FOR_NODE_TYPES() {
return [Node.TEXT_NODE]
Expand Down Expand Up @@ -858,7 +858,7 @@ describe('Binding attribute syntax', function () {
}
}

let tp = new TestProvider()
const tp = new TestProvider()
tp.bindingHandlers = originalBindingProvider.bindingHandlers
options.bindingProviderInstance = tp
})
Expand Down
2 changes: 1 addition & 1 deletion packages/bind/spec/bindingCompletionPromiseBehavior.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('Binding Application Promise', function () {

beforeEach(function () {
// Set up the default binding handlers.
let provider = new MultiProvider({ providers: [new VirtualProvider(), new DataBindProvider()] })
const provider = new MultiProvider({ providers: [new VirtualProvider(), new DataBindProvider()] })
options.bindingProviderInstance = provider
bindingHandlers = provider.bindingHandlers
bindingHandlers.set(coreBindings)
Expand Down
Loading