Skip to content

Add test for string permutation #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashokdey merged 4 commits into from
Oct 4, 2019
Merged

Add test for string permutation #23

ashokdey merged 4 commits into from
Oct 4, 2019

Conversation

@marcelinol
Copy link

@marcelinol marcelinol commented Oct 4, 2019

👨‍🚀 What's inside

  • Tests for string permutation
  • Changes to make the get-string-permutations problem more consistent with the repository existing standards
  • Cover case of an empty string in the get-string-permutations algorithm

Luciano Medeiros Marcelino added 4 commits October 3, 2019 20:10
Adjust file to keep consistency
0733efc 
The whole repository uses 2 spaces for indentation and does not use
console.log anywhere.
Also the repo standard is to use dash to separate words in the folders
names.
Add tests for get-string-permutation
5345bd7
Cover case of an empty string in get-string-permutations
7707918 
When adding a test case for an empty string, the code was looping
endlessly.
Fix readme to reflect new filename
f1a551c
@ashokdey ashokdey self-requested a review October 4, 2019 08:11
ashokdey
ashokdey approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@ashokdey ashokdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @marcelinol 🏆

@ashokdey ashokdey merged commit aae5ade into knaxus:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashokdey ashokdey ashokdey approved these changes

Assignees

@marcelinol marcelinol

Labels

review-complete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcelinol @ashokdey