fix(web): fix-dispute-template-presets-in-dev-ui #1627

tractorss · 2024-06-25T12:45:45Z

⚠️ has big bundle size, wait for #1506 to be merged first

PR-Codex overview

The focus of this PR is to add functionality to fetch dispute request parameters from a transaction on a specific EVM chain.

Detailed summary

Updated txnHash values in FetchDisputeRequestInput.tsx
Added getChain function to retrieve chain object
Modified getDisputeRequestParamsFromTxn to use createPublicClient with chain object and http transport
Added error logging in case of failure

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Updated transaction hashes for "Escrow" and "Curated Lists" presets to reflect the correct values.
Improvements
- Enhanced functionality for dispute request parameter retrieval to improve chain object identification.

coderabbitai · 2024-06-25T12:45:52Z

Walkthrough

The changes primarily involve updating transaction hash values in the FetchDisputeRequestInput.tsx file and modifying the getDisputeRequestParamsFromTxn function in getDisputeRequestParamsFromTxn.ts. Specifically, the transaction hashes for the "Escrow" and "Curated Lists" presets have been replaced. Additionally, the getDisputeRequestParamsFromTxn function has been enhanced with new parameters, and a new getChain function was introduced for fetching chain objects based on chain ID.

Changes

File Path	Change Summary
`web/src/pages/DisputeTemplateView/FetchDisputeRequestInput.tsx`	Updated transaction hash values for "Escrow" and "Curated Lists" presets.
`web/src/utils/getDisputeRequestParamsFromTxn.ts`	Enhanced `getDisputeRequestParamsFromTxn` function with new parameters and added a `getChain` function to retrieve chain objects based on chain ID.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant App
    participant ChainService

    User ->> App: Requests dispute params with txn hash
    App ->> ChainService: Calls getChain with chainId
    ChainService -->> App: Returns chain object
    App ->> ChainService: Calls createPublicClient with txn hash and chain object
    ChainService -->> App: Returns dispute params
    App -->> User: Responds with dispute params

Poem

In code we trust, with chains entwined,
Hashes updated, new paths aligned,
Disputes resolved with clearer sight,
Functions enhanced in digital light.
A rabbit’s cheer, for changes wise,
Our code ascends to new highs! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-06-25T12:46:01Z

✅ Deploy Preview for kleros-v2 ready!

Name	Link
🔨 Latest commit	`5188d2f`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2/deploys/667bf92da6c53c0008454f38
😎 Deploy Preview	https://deploy-preview-1627--kleros-v2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-06-25T12:46:01Z

✅ Deploy Preview for kleros-v2-university ready!

Name	Link
🔨 Latest commit	`5188d2f`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-university/deploys/667bf92d6366360008dd7087
😎 Deploy Preview	https://deploy-preview-1627--kleros-v2-university.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-06-25T12:46:07Z

✅ Deploy Preview for kleros-v2-neo ready!

Name	Link
🔨 Latest commit	`5188d2f`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-neo/deploys/667bf92d44eda30008f0d73a
😎 Deploy Preview	https://deploy-preview-1627--kleros-v2-neo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

web/src/utils/getDisputeRequestParamsFromTxn.ts (1)
Line range hint 24-53: Review of getDisputeRequestParamsFromTxn function.

Error Logging: The error logging in the catch block could be more informative. Include more context or the actual error message.

Bundle Size Warning: The comment about large bundle size is good, but consider if there's a way to reduce the import size or split the code.

Use of Async/Await: Proper use of async/await for asynchronous calls.

Error Handling: Good use of try-catch for error handling, but the catch block could be more descriptive.
- console.log("Error getting txn :", { e });
+ console.error("Failed to get transaction receipt for hash:", hash, "Error:", e.message);
Consider modularizing this function further if it's contributing significantly to the bundle size, possibly by lazy loading some dependencies.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6ac5035 and 0736c54.

Files selected for processing (2)

web/src/pages/DisputeTemplateView/FetchDisputeRequestInput.tsx (1 hunks)
web/src/utils/getDisputeRequestParamsFromTxn.ts (2 hunks)

Files skipped from review due to trivial changes (1)

web/src/pages/DisputeTemplateView/FetchDisputeRequestInput.tsx

web/src/utils/getDisputeRequestParamsFromTxn.ts

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0736c54 and c538b43.

Files selected for processing (2)

web/src/pages/DisputeTemplateView/FetchDisputeRequestInput.tsx (1 hunks)
web/src/utils/getDisputeRequestParamsFromTxn.ts (2 hunks)

Files skipped from review as they are similar to previous changes (2)

web/src/pages/DisputeTemplateView/FetchDisputeRequestInput.tsx
web/src/utils/getDisputeRequestParamsFromTxn.ts

codeclimate · 2024-06-26T11:19:51Z

Code Climate has analyzed commit 5188d2f and detected 0 issues on this pull request.

View more on Code Climate.

sonarqubecloud · 2024-06-26T11:20:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c538b43 and 5188d2f.

Files selected for processing (1)

web/src/pages/DisputeTemplateView/FetchDisputeRequestInput.tsx (1 hunks)

Additional comments not posted (2)

web/src/pages/DisputeTemplateView/FetchDisputeRequestInput.tsx (2)

49-49: Verify the new transaction hash for "Escrow".

Ensure that the new transaction hash 0x85e60cb407c9a38e625263cc762ff4283d01f38201825e1d20109d8664cfa7d4 is correct and valid for the intended use case.

54-54: Verify the new transaction hash for "Curated Lists".

Ensure that the new transaction hash 0x6e5ad6f7436ef8570b50b0fbec76a11ccedbed85030c670e59d8f6617a499108 is correct and valid for the intended use case.

coderabbitai bot requested changes Jun 25, 2024

View reviewed changes

web/src/utils/getDisputeRequestParamsFromTxn.ts Show resolved Hide resolved

coderabbitai bot previously approved these changes Jun 25, 2024

View reviewed changes

fix(web): fix-dispute-template-presets-in-dev-ui

c538b43

tractorss force-pushed the fix/fix-dispute-template-previews-in-dev-ui branch from 0736c54 to c538b43 Compare June 26, 2024 11:00

coderabbitai bot reviewed Jun 26, 2024

View reviewed changes

chore(web): update-curate-preset-txn

5188d2f

tractorss dismissed coderabbitai[bot]’s stale review via 5188d2f June 26, 2024 11:19

jaybuidl marked this pull request as ready for review July 25, 2024 12:30

jaybuidl self-requested a review July 25, 2024 12:30

jaybuidl approved these changes Jul 25, 2024

View reviewed changes

jaybuidl added this pull request to the merge queue Jul 25, 2024

jaybuidl added Type: Bug 🐛 Package: Web Court web frontend labels Jul 25, 2024

coderabbitai bot reviewed Jul 25, 2024

View reviewed changes

coderabbitai bot approved these changes Jul 25, 2024

View reviewed changes

Merged via the queue into dev with commit 7c63037 Jul 25, 2024
22 of 23 checks passed

jaybuidl deleted the fix/fix-dispute-template-previews-in-dev-ui branch October 8, 2024 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(web): fix-dispute-template-presets-in-dev-ui #1627

fix(web): fix-dispute-template-presets-in-dev-ui #1627

Uh oh!

tractorss commented Jun 25, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 25, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

netlify bot commented Jun 25, 2024 •

edited

Loading

Uh oh!

netlify bot commented Jun 25, 2024 •

edited

Loading

Uh oh!

netlify bot commented Jun 25, 2024 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

codeclimate bot commented Jun 26, 2024

Uh oh!

sonarqubecloud bot commented Jun 26, 2024

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

fix(web): fix-dispute-template-presets-in-dev-ui #1627

fix(web): fix-dispute-template-presets-in-dev-ui #1627

Uh oh!

Conversation

tractorss commented Jun 25, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

netlify bot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kleros-v2 ready!

Uh oh!

netlify bot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kleros-v2-university ready!

Uh oh!

netlify bot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kleros-v2-neo ready!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codeclimate bot commented Jun 26, 2024

Uh oh!

sonarqubecloud bot commented Jun 26, 2024

Quality Gate passed

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tractorss commented Jun 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 25, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading

netlify bot commented Jun 25, 2024 •

edited

Loading