Skip to content

fix(web): move-template-population-to-use-dispute-template-hook #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

tractorss
Copy link
Contributor

@tractorss tractorss commented Jan 30, 2024

  • Moved the template population logic to the useDisputeTemplate hook itself

PR-Codex overview

Detailed summary:

  • This PR updates multiple files to replace the usage of useDisputeTemplate with usePopulatedDisputeData to fetch dispute details.
  • It also replaces the usage of disputeTemplate with disputeDetails in various components.
  • The INVALID_DISPUTE_DATA_ERROR constant is imported and used in place of a fallback text.
  • The INVALID_DISPUTE_DATA_ERROR constant is imported and used in place of a fallback text.

The following files were skipped due to too many changes: web/src/pages/Cases/CaseDetails/Voting/Classic/Reveal.tsx, web/src/hooks/queries/useDisputeTemplate.ts, web/src/pages/Cases/CaseDetails/Overview/index.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 4dd0d16
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65bbc7307c28490008f0e07c
😎 Deploy Preview https://deploy-preview-1465--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alcercu
alcercu previously approved these changes Feb 1, 2024
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codeclimate bot commented Feb 1, 2024

Code Climate has analyzed commit 4dd0d16 and detected 28 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 28

View more on Code Climate.

Copy link

sonarqubecloud bot commented Feb 1, 2024

@alcercu alcercu added this pull request to the merge queue Feb 1, 2024
Merged via the queue into dev with commit 6fc7588 Feb 1, 2024
@jaybuidl jaybuidl deleted the fix(web)/use-dispute-template-fix branch October 8, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants