Skip to content

Conversation

@tractorss
Copy link
Contributor

@tractorss tractorss commented Dec 22, 2023

  1. This fixes the stake info not showing in the courts UI.
    The stake updating logic was commented
  2. Also fixes subgraph breaking due to sortitionModule ABI not present in KlerosCore datasource.
  3. Updated the handlers, we can index the sortitionModule separately ,but it makes more sense as a dataSource in core and intertvines with other functions too (Both KlerosCore and SortitionModule trigger JurorTokensPerCourt entitity update)

PR-Codex overview

Detailed summary

  • Updated the handleStakeDelayedAlreadyTransferred and handleStakeDelayedAlreadyTransferredWithdrawn functions in SortitionModule.ts to use the event.params._amount instead of zero for updating the delayed stake.
  • Removed commented out code in JurorTokensPerCourt.ts related to updating juror stakes and court information.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit f68fb49
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/6585428f5778f9000865822a
😎 Deploy Preview https://deploy-preview-1375--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit f68fb49 and detected 49 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 10
Duplication 14
Style 25

View more on Code Climate.

@sonarqubecloud
Copy link

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu added this pull request to the merge queue Dec 22, 2023
Merged via the queue into dev with commit b663792 Dec 22, 2023
@jaybuidl jaybuidl added this to the testnet-3 milestone Dec 27, 2023
@jaybuidl jaybuidl deleted the fix(subgraph)/fix-stake-handlers branch January 3, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants