refactor(web): align-debug-component-content #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alcercu
requested changes
Dec 12, 2023
| @@ -54,7 +59,7 @@ const Phase = () => { | |||
| const { data: phase } = useSortitionModulePhase({ | |||
| watch: true, | |||
| }); | |||
| return <>{phase !== undefined && <label>Phase: {Phases[phase]}</label>}</>; | |||
| return <>{phase !== undefined && <StyledLabel>Phase: {Phases[phase]}</StyledLabel>}</>; | |||
There was a problem hiding this comment.
Lately I have been trying to use the following syntax for this situations:
Suggested change
| return <>{phase !== undefined && <StyledLabel>Phase: {Phases[phase]}</StyledLabel>}</>; | |
| return (phase !== undefined ? <StyledLabel>Phase: {Phases[phase]}</StyledLabel> : null); |
(also, try using the isUndefined function from utils/index.ts)
|
|
Code Climate has analyzed commit 27e7fd2 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the styling and adding conditional rendering in the Debug component.
Detailed summary