Skip to content

refactor(web): extract-calc-to-ResponsiveSize-func #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

tractorss
Copy link
Contributor

@tractorss tractorss commented Dec 6, 2023

Extracted calc function used in css for making properties responsive to a seperate "ResponsiveSize" function


PR-Codex overview

Detailed summary

  • Import of responsiveSize from styles/responsiveSize added to multiple files.
  • Usage of responsiveSize function to set margin, padding, width, and height values in styled components.
  • The responsiveSize function calculates responsive values based on the viewport width.

The following files were skipped due to too many changes: web/src/components/Verdict/DisputeTimeline.tsx, web/src/components/DisputeCard/DisputeInfo.tsx, web/src/layout/Header/navbar/Menu/Settings/index.tsx, web/src/pages/Home/TopJurors/JurorCard/DesktopCard.tsx, web/src/pages/Courts/index.tsx, web/src/pages/Cases/index.tsx, web/src/pages/Cases/CaseDetails/Voting/index.tsx, web/src/components/CasesDisplay/index.tsx, web/src/pages/Home/index.tsx, web/src/components/Popup/MiniGuides/Onboarding/PnkLogoAndTitle.tsx, web/src/components/Popup/ExtraInfo/StakeWithdrawExtraInfo.tsx, web/src/pages/Home/CourtOverview/Stats.tsx, web/src/pages/Home/TopJurors/Header/DesktopHeader.tsx, web/src/styles/responsiveSize.ts, web/src/pages/Courts/CourtDetails/index.tsx, web/src/layout/Header/DesktopHeader.tsx, web/src/pages/Cases/CaseDetails/Overview/Policies.tsx, web/src/pages/Cases/CaseDetails/Timeline.tsx, web/src/pages/Dashboard/index.tsx, web/src/layout/Header/navbar/DappList.tsx, web/src/components/DisputeCard/index.tsx, web/src/components/EvidenceCard.tsx, web/src/components/Popup/Description/Appeal.tsx, web/src/components/CasesDisplay/CasesListHeader.tsx, web/src/components/Popup/Description/StakeWithdraw.tsx, web/src/components/Popup/index.tsx, web/src/components/Popup/MiniGuides/MainStructureTemplate.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@tractorss tractorss requested a review from alcercu December 6, 2023 16:47
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 49498e2
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/657870b0d4d21d000802cf53
😎 Deploy Preview https://deploy-preview-1350--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit 49498e2 and detected 26 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 26

View more on Code Climate.

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu added this pull request to the merge queue Dec 12, 2023
Merged via the queue into dev with commit edbee9d Dec 12, 2023
@jaybuidl jaybuidl added this to the testnet-3 milestone Dec 27, 2023
@jaybuidl jaybuidl deleted the refactor(web)/extract-calc-to-ResponsiveSize-function branch January 3, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants