Skip to content

chore(web): update footer links #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Nov 2, 2024

PR-Codex overview

This PR introduces a new YouTube logo SVG and updates the socialmedia configuration to include a youtube entry with its corresponding URL. It also removes unused social media logos from the socialmedia.tsx file.

Detailed summary

  • Added youtube.svg SVG file.
  • Imported YouTubeLogo in socialmedia.tsx.
  • Added youtube entry in the socialmedia object with the URL https://youtube.com/@kleros_io.
  • Removed unused imports for EtherscanLogo, SnapshotLogo, RedditLogo, and GhostBlogLogo.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Added a new YouTube entry with icon and URL for improved social media connectivity.
  • Changes
    • Removed entries for Etherscan, Snapshot, Reddit, and Ghost Blog.
    • Retained and reorganized existing entries for Github, Discord, and Telegram.

Copy link
Contributor

coderabbitai bot commented Nov 2, 2024

Walkthrough

The changes involve modifications to the socialmedia object in the web/src/consts/socialmedia.tsx file. Several social media entries have been removed, including Etherscan, Snapshot, Reddit, and Ghost Blog. The existing entries for Github, Discord, and Telegram have been retained but reorganized. A new entry for YouTube has been added, which includes an icon and a URL. The overall structure of the socialmedia object remains intact, but the platforms represented have been updated.

Changes

File Change Summary
web/src/consts/socialmedia.tsx Removed entries: Etherscan, Snapshot, Reddit, Ghost Blog; Updated URLs for Github, Discord, Telegram; Added entry for YouTube with icon and URL.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SocialMedia

    User->>SocialMedia: Request social media links
    SocialMedia-->>User: Return updated social media links (Github, Discord, Telegram, YouTube)
Loading

🐰 In the meadow, changes bloom,
Social links shift, making room.
Etherscan hops away,
YouTube joins the fray,
Discord and Telegram, still in tune,
A fresh new look, like a bright full moon! 🌕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d208c9a and e050fd8.

⛔ Files ignored due to path filters (1)
  • web/src/assets/svgs/socialmedia/youtube.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • web/src/consts/socialmedia.tsx (1 hunks)
🔇 Additional comments (3)
web/src/consts/socialmedia.tsx (3)

1-8: LGTM! Import statements are well-organized.

All imports are being used and follow a consistent pattern.


Line range hint 11-35: LGTM! Social media entries are well-structured and organized.

The social media platforms are logically grouped:

  1. Messaging platforms (Telegram, X, Discord)
  2. Content platforms (YouTube)
  3. Development/Professional platforms (GitHub, LinkedIn)

Let's verify if the Discord invite link is permanent:


Line range hint 11-35: Verify HTTPS usage in all social media URLs.

While all URLs in this file correctly use HTTPS, let's ensure consistency across the codebase.

✅ Verification successful

All social media URLs correctly use HTTPS protocol

Based on the search results, all social media URLs in the codebase consistently use HTTPS. This includes URLs for:

  • X (Twitter)
  • Discord
  • YouTube
  • GitHub
  • LinkedIn
  • Telegram

No instances of HTTP (non-secure) social media URLs were found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any HTTP (non-secure) social media URLs
rg "http://(twitter|x|telegram|discord|youtube|github|linkedin)" --type-add 'config:*.{json,js,ts,tsx,yml,yaml}' -t config

Length of output: 124


Script:

#!/bin/bash
# Let's broaden the search to catch any HTTP URLs in files that might contain social media links
rg -i "http://" --type=ts --type=tsx --type=js --type=jsx --type=json

# Also search for social media URLs specifically (both HTTP and HTTPS)
rg -i "(https?://)?(www\.)?(twitter\.com|x\.com|telegram\.(org|me)|discord\.com|youtube\.com|github\.com|linkedin\.com)" --type=ts --type=tsx --type=js --type=jsx --type=json

Length of output: 302


Script:

#!/bin/bash
# Search for any HTTP URLs in all files, without type filtering
rg -i "http://" 

# Also do a specific search for social media URLs
rg -i "(https?://)?(www\.)?(twitter\.com|x\.com|telegram\.(org|me)|discord\.com|youtube\.com|github\.com|linkedin\.com)"

Length of output: 88593


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for kleros-escrow-v2 ready!

Name Link
🔨 Latest commit e050fd8
🔍 Latest deploy log https://app.netlify.com/sites/kleros-escrow-v2/deploys/6725a43356962600081f398f
😎 Deploy Preview https://deploy-preview-84--kleros-escrow-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu merged commit bcc0d80 into master Nov 4, 2024
5 of 7 checks passed
@alcercu alcercu deleted the chore(web)/update-footer-links branch November 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants