This repository was archived by the owner on Jan 4, 2020. It is now read-only.
광일공방 중고나라 #1, #2 코드리뷰 부탁드립니다. #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
task2_original_jaeju는 파일에 저장하는 방식을 기반으로 처음 작성했던 스크립트이고, taks2_jaeju는 토요일 모임 후에 새로 짜본 코드입니다.
kwangilcho
reviewed
Jan 20, 2019
Contributor
kwangilcho
left a comment
kwangilcho
left a comment
There was a problem hiding this comment.
아주 좋습니다. 앞으로 이런 식으로 코드리뷰를 받으시면 되겠습니다.
새로 작성해주신 파일에 대해서만 코드리뷰를 진행하였습니다.
| print('3. 삭제하기') | ||
| print('-------------------------------------') | ||
|
|
||
| def action_execution(self): |
Contributor
There was a problem hiding this comment.
함수 이름은 동사로 시작하는 것이 좋습니다.
execute_action은 어떨까요?
Author
There was a problem hiding this comment.
아 그렇네요!
함수 자체의 실행적 느낌을 살려서 네이밍 해보도록 하겠습니다!
| except IndexError: | ||
| print('범위 밖의 숫자를 입력하셨습니다.') | ||
|
|
||
| def action_list(self): |
Contributor
There was a problem hiding this comment.
함수 이름은 동사로 시작하는 것이 좋습니다.
list_actions은 어떨까요?
Author
There was a problem hiding this comment.
아 이 부분도 action_list라고 하면 action들의 리스트라는 느낌이 더 강하겠네요!
감사합니다!
| if post_no < 1 or post_no > len(self.posts): | ||
| raise IndexError | ||
| del self.posts[post_no -1] | ||
| except ValueError: |
| return | ||
|
|
||
| for index, post in enumerate(self.posts): | ||
| print('{글번호}. {글내용}'.format(글번호 = str(index + 1), 글내용 = post)) |
Contributor
There was a problem hiding this comment.
formatted string 활용이 돋보입니다.
| board.show_posts() | ||
| board.action_list() | ||
| board.action_execution() | ||
| os.system('cls' if os.name == 'nt' else 'clear') |
Contributor
There was a problem hiding this comment.
clear_screen() 함수를 만들어 놓고 쓰지 않았네요.
Author
There was a problem hiding this comment.
아 그렇네요...ㅎㅎ
clear_screen 함수를 나중에 작성하고
바꾸질 못했네요
감사합니다!
wbluke
added a commit
to wbluke/101
that referenced
this pull request
Feb 10, 2019
jjj0611
added a commit
to jjj0611/101
that referenced
this pull request
Feb 11, 2019
jiwooo-kim
added a commit
to jiwooo-kim/101
that referenced
this pull request
Feb 21, 2019
jamesjahng
added a commit
to jamesjahng/101
that referenced
this pull request
Feb 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2번 과제에서 txt 파일에 직접 저장해야한다고 잘못 생각해서 작성한 코드와
토요일에 새롭게 작성해본 코드 두 가지 다 올립니다.