Custom Service notification #2703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misl6
reviewed
Dec 8, 2022
There was a problem hiding this comment.
Hi @RobertFlatt !
Thank you for such a feature! I've added a couple of comments, please let me know what do you think about it 😀
pythonforandroid/bootstraps/common/build/templates/Service.tmpl.java
Outdated
Show resolved
Hide resolved
pythonforandroid/bootstraps/service_library/build/templates/Service.tmpl.java
Outdated
Show resolved
Hide resolved
|
Hey @misl6 , this work for you? |
shyamnathp
pushed a commit
to shyamnathp/python-for-android
that referenced
this pull request
Feb 17, 2023
* add_resources * add_resource * Update build.py * stateless * multiple kinds * pep8 * --add_resource * Custom notification * Update Service.tmpl.java * Custom Notification * Custom Notification * service notification * customize notification * share code * share code * Update Service.tmpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Android Service, when started, displays a service icon (in the task bar) and a notification message (in the notification shade history).
For a p4a app the icon and notification are not user configurable. The service icon is some sub region of the app launch icon, and the notification content is the service name. I characterize this as proof-of-concept functionality.
This PR overloads the service
start()method with a new method having 3 extra string parameters: 'icon resource name', 'notification title', and 'notification text'. The PR applies these extra parameters, and separately we make notification channel names unique. Changes occur in the common, service_only, and service_library bootstraps.A test case may be found here https://github.com/RobertFlatt/service_icon_test
As a side note the current p4a service implementation depends on a depreciated api, have added a comment to identify this.