Skip to content

webview: add mOpenExternalLinksInBrowser field #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2021
Merged

webview: add mOpenExternalLinksInBrowser field #2387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pythonforandroid/bootstraps/webview/build/src/main/java/org/kivy/android/PythonActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

import android.webkit.WebViewClient;
import android.webkit.WebView;
import android.net.Uri;

import org.renpy.android.ResourceManager;

Expand All @@ -45,6 +46,7 @@ public class PythonActivity extends Activity {
private static final String TAG = "PythonActivity";

public static PythonActivity mActivity = null;
public static boolean mOpenExternalLinksInBrowser = false;

/** If shared libraries (e.g. SDL or the native application) could not be loaded. */
public static boolean mBrokenLibraries;
Expand Down Expand Up @@ -163,6 +165,13 @@ public void onClick(DialogInterface dialog,int id) {
mWebView.setWebViewClient(new WebViewClient() {
@Override
public boolean shouldOverrideUrlLoading(WebView view, String url) {
if (mOpenExternalLinksInBrowser) {
if (!(url.startsWith("file:") || url.startsWith("http://127.0.0.1:"))) {
Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
startActivity(i);
return true;
}
}
view.loadUrl(url);
return false;
}
Expand Down