Skip to content

fix: use animated reaction instead of derivation #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2023
Merged

fix: use animated reaction instead of derivation #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b03269
fix: use animated reaction instead of derivation
vonovak Oct 6, 2023
3361787
fix: use animated reaction in fabric example too
vonovak Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions FabricExample/src/screens/Examples/AwareScrollView/useSmoothKeyboardHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Platform } from 'react-native';
import {
Easing,
useDerivedValue,
useAnimatedReaction,
useSharedValue,
withTiming,
} from 'react-native-reanimated';
Expand Down Expand Up @@ -37,8 +37,11 @@ export const useSmoothKeyboardHandler: typeof useKeyboardHandler = (
const persistedHeight = useSharedValue(0);
const animatedKeyboardHeight = useSharedValue(0);

useDerivedValue(() => {
if (!IS_ANDROID_ELEVEN_OR_HIGHER_OR_IOS) {
useAnimatedReaction(
() => {
if (IS_ANDROID_ELEVEN_OR_HIGHER_OR_IOS) {
return;
}
const event = {
// it'll be always 250, since we're running animation via `withTiming` where
// duration in config (TELEGRAM_ANDROID_TIMING_CONFIG.duration) = 250ms
Expand All @@ -47,14 +50,21 @@ export const useSmoothKeyboardHandler: typeof useKeyboardHandler = (
height: animatedKeyboardHeight.value,
progress: animatedKeyboardHeight.value / persistedHeight.value,
};
handler.onMove?.(event);
return event;
},
(evt) => {
if (!evt) {
return;
}
handler.onMove?.(evt);

// dispatch `onEnd`
if (animatedKeyboardHeight.value === persistedHeight.value) {
handler.onEnd?.(event);
handler.onEnd?.(evt);
}
}
}, []);
},
[handler]
);

useKeyboardHandler(
{
Expand Down
24 changes: 17 additions & 7 deletions example/src/screens/Examples/AwareScrollView/useSmoothKeyboardHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Platform } from 'react-native';
import {
Easing,
useDerivedValue,
useAnimatedReaction,
useSharedValue,
withTiming,
} from 'react-native-reanimated';
Expand Down Expand Up @@ -37,8 +37,11 @@ export const useSmoothKeyboardHandler: typeof useKeyboardHandler = (
const persistedHeight = useSharedValue(0);
const animatedKeyboardHeight = useSharedValue(0);

useDerivedValue(() => {
if (!IS_ANDROID_ELEVEN_OR_HIGHER_OR_IOS) {
useAnimatedReaction(
() => {
if (IS_ANDROID_ELEVEN_OR_HIGHER_OR_IOS) {
return;
}
const event = {
// it'll be always 250, since we're running animation via `withTiming` where
// duration in config (TELEGRAM_ANDROID_TIMING_CONFIG.duration) = 250ms
Expand All @@ -47,14 +50,21 @@ export const useSmoothKeyboardHandler: typeof useKeyboardHandler = (
height: animatedKeyboardHeight.value,
progress: animatedKeyboardHeight.value / persistedHeight.value,
};
handler.onMove?.(event);
return event;
},
(evt) => {
if (!evt) {
return;
}
handler.onMove?.(evt);

// dispatch `onEnd`
if (animatedKeyboardHeight.value === persistedHeight.value) {
handler.onEnd?.(event);
handler.onEnd?.(evt);
}
}
}, []);
},
[handler]
);

useKeyboardHandler(
{
Expand Down