This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix missing return statements in module stubs #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes build with -Werror=return-type
twofish.c: In function 'init_twofish':
twofish.c:45:1: error: control reaches end of non-void function [-Werror=return-type]
45 | PyMODINIT_FUNC init_twofish(void) { }
| ^~~~~~~~~~~~~~
twofish.c: In function 'PyInit__twofish':
twofish.c:46:1: error: control reaches end of non-void function [-Werror=return-type]
46 | PyMODINIT_FUNC PyInit__twofish(void) { }
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Signed-off-by: Martin Jansa <[email protected]>
flowergom
pushed a commit
to webosose/meta-webosose
that referenced
this pull request
Oct 21, 2019
:Release Notes: Like oe-core/meta/conf/distro/include/security_flags.inc does. :Detailed Notes: This way it gets applied to all builds which respect at least CC even when they don't respect CFLAGS/CXXFLAGS set in OE environment. Remove the whitelist for python3-twisted, it didn't work, because it still got -Werror=return-type from python3 config and it was fixed properly in: keybase/python-twofish#6 http://lists.openembedded.org/pipermail/openembedded-devel/2019-August/201118.html and drop redis as well, with proper fix here: http://lists.openembedded.org/pipermail/openembedded-devel/2019-August/201116.html :Testing Performed: :QA Notes: :Issues Addressed: [PLAT-79213] Missing return statements from non-void functions [PLAT-84440] CCC: Various build fixes Change-Id: If997b648f42ae02091b97053a51eeb462f561c7e
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Oct 21, 2019
:Release Notes: Like oe-core/meta/conf/distro/include/security_flags.inc does. :Detailed Notes: This way it gets applied to all builds which respect at least CC even when they don't respect CFLAGS/CXXFLAGS set in OE environment. Remove the whitelist for python3-twisted, it didn't work, because it still got -Werror=return-type from python3 config and it was fixed properly in: keybase/python-twofish#6 http://lists.openembedded.org/pipermail/openembedded-devel/2019-August/201118.html and drop redis as well, with proper fix here: http://lists.openembedded.org/pipermail/openembedded-devel/2019-August/201116.html :Testing Performed: :QA Notes: :Issues Addressed: [PLAT-79213] Missing return statements from non-void functions [PLAT-84440] CCC: Various build fixes Change-Id: If997b648f42ae02091b97053a51eeb462f561c7e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twofish.c: In function 'init_twofish':
twofish.c:45:1: error: control reaches end of non-void function [-Werror=return-type]
45 | PyMODINIT_FUNC init_twofish(void) { }
| ^~~~~~~~~~~~~~
twofish.c: In function 'PyInit__twofish':
twofish.c:46:1: error: control reaches end of non-void function [-Werror=return-type]
46 | PyMODINIT_FUNC PyInit__twofish(void) { }
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Signed-off-by: Martin Jansa [email protected]