Bump Finit to fix flaky DHCP server subnets test #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduce complexity - Change type, simplify - Allow errors from initctl Signed-off-by: Joachim Wiberg <[email protected]>
wkz
approved these changes
Feb 14, 2025
Primarily fixes issue with DHCP server multiple subnets test, which triggers an ordering issue between reconfiguration of dnsmasq and the `initctl reload` command. For the full ChangeLog, please see: https://github.com/troglobit/finit/releases/tag/4.9 Signed-off-by: Joachim Wiberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Infix regression tests perform rapid configuration changes, where the time between the last
initctl touchcommand andinitctl reloadis very short, the reload event may be received by Finit before the kernel inotify event for the last touched files. This caused Finit to not restart (or SIGHUP) the affected services.Fixes #936
Checklist
Tick relevant boxes, this PR is-a or has-a: