Skip to content

Conversation

@troglobit
Copy link
Contributor

@troglobit troglobit commented Dec 5, 2025

Description

This PR adds diagnostic data and additional logging to catch the root cause for issue #1303:

  • Exactly when and why cleanup is called
  • Whether the cd /tmp command succeeds
  • The actual tar exit code (not just 255 from SSH)
  • Whether cleanup happens before tar completes (race condition)
  • The full collection.log showing the sequence of events

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe): support collection tool

This patch adds diagnostic data and additional logging to catch the root
cause for issue #1303:

  - Exactly when and why cleanup is called
  - Whether the cd /tmp command succeeds
  - The actual tar exit code (not just 255 from SSH)
  - Whether cleanup happens before tar completes (race condition)
  - The full collection.log showing the sequence of events

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit troglobit requested a review from wkz December 5, 2025 16:41
@troglobit troglobit marked this pull request as ready for review December 5, 2025 16:41
Does not really fit under "System Configuration".

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit troglobit linked an issue Dec 5, 2025 that may be closed by this pull request
@troglobit troglobit mentioned this pull request Dec 6, 2025
17 tasks
@troglobit troglobit merged commit 5e353a8 into main Dec 6, 2025
7 checks passed
@troglobit troglobit deleted the flaky branch December 6, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test misc/support_collect fails on --work-dir step

3 participants