Skip to content

Conversation

@troglobit
Copy link
Contributor

Description

Misc. fixes for issues seen in -rc1.

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

There is no such loglevel 'critical', only 'crit' is defined.

For some reason this issue has not been spotted until the upgrade to
Buildroot 2025.02, which includes sysklogd v2.7.0, and Finit v4.11.

Introduced in 3e48af6, when the concept of failure-config was added.

Signed-off-by: Joachim Wiberg <[email protected]>
This silences a bogus warning in the log when runparts is called with no
argument.  I.e., when there is no product specific init files available.

Signed-off-by: Joachim Wiberg <[email protected]>
Buildroot 2025.02 currently has sysklogd v2.7.0, which has new features,
but also a few bugs.  This commit drops all patches for v2.5.2 and adds
all patches for sysklogd v2.7.2

For more information, see:

 - https://github.com/troglobit/sysklogd/releases/tag/v2.7.1
 - https://github.com/troglobit/sysklogd/releases/tag/v2.7.2

Signed-off-by: Joachim Wiberg <[email protected]>
@troglobit troglobit requested review from Copilot and mattiaswal March 31, 2025 11:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses miscellaneous fixes related to logging issues found in -rc1.

  • Updated the changelog to document fixes for an annoying logger usage message, a harmless log warning, and sysklogd hostname filtering and TAG name issues.
  • Backported fixes are highlighted pending future official updates in Buildroot.
Files not reviewed (19)
  • board/common/rootfs/usr/libexec/infix/init.d/05-product: Language not supported
  • package/confd/confd.conf: Language not supported
  • patches/sysklogd/2.5.2/0001-Fix-72-loss-of-raw-kernel-log-messages-to-console.patch: Language not supported
  • patches/sysklogd/2.5.2/0002-Fix-80-add-global-log-rotation-options-to-.conf-file.patch: Language not supported
  • patches/sysklogd/2.5.2/0003-Refactor-rely-on-global-file-rotation-if-not-set-per.patch: Language not supported
  • patches/sysklogd/2.5.2/0004-Allow-per-file-rotation-settings-to-set-only-one-val.patch: Language not supported
  • patches/sysklogd/2.5.2/0005-Fix-81-blocking-delay-for-unreachable-remote.patch: Language not supported
  • patches/sysklogd/2.5.2/0006-Fix-annoying-gcc-warning-in-rotate_file.patch: Language not supported
  • patches/sysklogd/2.5.2/0007-Refactor-cfparse-to-add-a-per-keyword-parser.patch: Language not supported
  • patches/sysklogd/2.5.2/0008-Fix-gcc-warning-in-vsyslogp_r.patch: Language not supported
  • patches/sysklogd/2.5.2/0009-Fix-83-add-support-for-listen-addr-port-to-.conf-fil.patch: Language not supported
  • patches/sysklogd/2.5.2/0010-Fix-82-retry-creating-UNIX-and-network-sockets-on-fa.patch: Language not supported
  • patches/sysklogd/2.5.2/0011-Read-.conf-files-from-include-directories-sorted.patch: Language not supported
  • patches/sysklogd/2.5.2/0012-Fix-87-segfault-on-shutdown.patch: Language not supported
  • patches/sysklogd/2.5.2/0013-Fix-85-logging-to-remote-IPv6-address-does-not-work.patch: Language not supported
  • patches/sysklogd/2.5.2/0014-Fix-86-adapt-facilities-for-RFC5424-compliance.patch: Language not supported
  • patches/sysklogd/2.5.2/0015-Fix-88-initial-delay-for-unresolvable-remote-target.patch: Language not supported
  • patches/sysklogd/2.5.2/0016-Fix-89-data-corruption-using-.conf-file-listen-direc.patch: Language not supported
  • patches/sysklogd/2.5.2/0017-Fix-90-add-support-for-IPv6-addresses-in-listen-dire.patch: Language not supported

Copy link
Contributor

@mattiaswal mattiaswal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mattiaswal mattiaswal merged commit 10f62f6 into main Mar 31, 2025
6 checks passed
@mattiaswal mattiaswal deleted the logging-fixes branch March 31, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants