Skip to content

Conversation

JenySadadia
Copy link
Collaborator

Rework CLI tools to interact with the API PubSub interface with Click framework.
Added kci event commands.

Copy link
Collaborator

@gctucker gctucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK this doesn't change any of the bindings so it can be done in parallel of the API class rework. Then when adding the queue commands etc. with new bindings, it would be good to do it directly on top of the reworked API class with a nested class for events.

Jeny Sadadia added 2 commits November 22, 2023 10:31
Rework CLI tools to interact with the API PubSub
interface with `Click` framework.
Rename group of commands from `kci pubsub` to `kci event`
and add sub-commands to subscribe, unsubscribe,
receive and send events.

Signed-off-by: Jeny Sadadia <[email protected]>
Remove CLI tool for API PubSub from `kernelci.legacy`
module as it has been reworked and added to
`kernelci.cli` module.

Signed-off-by: Jeny Sadadia <[email protected]>
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on staging:
subscribe, receive, unsubscribe, send

@nuclearcat nuclearcat added this pull request to the merge queue Nov 28, 2023
Merged via the queue into kernelci:main with commit 089b0c2 Nov 28, 2023
@JenySadadia JenySadadia deleted the rework-kci-pubsub branch November 28, 2023 10:16
@gctucker gctucker mentioned this pull request Dec 15, 2023
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants