selftests/bpf: improve reliability of test_perf_branches_no_hw() #10334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: d6ec090 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
7b6b51d to
2412df8
Compare
Author
|
Upstream branch: d6ec090 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1025376=>bpf-next
branch
from
aafe3a3 to
aa21554
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2412df8 to
bfb0726
Compare
Author
|
Upstream branch: d088da9 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1025376=>bpf-next
branch
from
aa21554 to
9806909
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
bfb0726 to
b0a5b86
Compare
Author
|
Upstream branch: e0940c6 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1025376=>bpf-next
branch
from
9806909 to
77d9ed1
Compare
Author
|
Upstream branch: e0940c6 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1025376=>bpf-next
branch
from
77d9ed1 to
82cb80c
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
b0a5b86 to
44cbecf
Compare
Author
|
Upstream branch: 792f258 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1025376=>bpf-next
branch
from
82cb80c to
6a1a085
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
44cbecf to
e8ba78a
Compare
Author
|
Upstream branch: 878ee3c |
Currently, test_perf_branches_no_hw() relies on the busy loop within test_perf_branches_common() being slow enough to allow at least one perf event sample tick to occur before starting to tear down the backing perf event BPF program. With a relatively small fixed iteration count of 1,000,000, this is not guaranteed on modern fast CPUs, resulting in the test run to subsequently fail with the following: bpf_testmod.ko is already unloaded. Loading bpf_testmod.ko... Successfully loaded bpf_testmod.ko. test_perf_branches_common:PASS:test_perf_branches_load 0 nsec test_perf_branches_common:PASS:attach_perf_event 0 nsec test_perf_branches_common:PASS:set_affinity 0 nsec check_good_sample:PASS:output not valid 0 nsec check_good_sample:PASS:read_branches_size 0 nsec check_good_sample:PASS:read_branches_stack 0 nsec check_good_sample:PASS:read_branches_stack 0 nsec check_good_sample:PASS:read_branches_global 0 nsec check_good_sample:PASS:read_branches_global 0 nsec check_good_sample:PASS:read_branches_size 0 nsec test_perf_branches_no_hw:PASS:perf_event_open 0 nsec test_perf_branches_common:PASS:test_perf_branches_load 0 nsec test_perf_branches_common:PASS:attach_perf_event 0 nsec test_perf_branches_common:PASS:set_affinity 0 nsec check_bad_sample:FAIL:output not valid no valid sample from prog Summary: 0/1 PASSED, 0 SKIPPED, 1 FAILED Successfully unloaded bpf_testmod.ko. On a modern CPU (i.e. one with a 3.5 GHz clock rate), executing 1 million increments of a volatile integer can take significantly less than 1 millisecond. If the spin loop and detachment of the perf event BPF program elapses before the first 1 ms sampling interval elapses, the perf event will never end up firing. Fix this by bumping the loop iteration counter a little within test_perf_branches_common(), along with ensuring adding another loop termination condition which is directly influenced by the backing perf event BPF program executing. Notably, a concious decision was made to not adjust the sample_freq value as that is just not a reliable way to go about fixing the problem. It effectively still leaves the race window open. Fixes: 67306f8 ("selftests/bpf: Add bpf_read_branch_records() selftest") Signed-off-by: Matt Bobrowski <[email protected]> Reviewed-by: Jiri Olsa <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1025376=>bpf-next
branch
from
6a1a085 to
f5abe87
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e8ba78a to
c1a1f03
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1025376 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: improve reliability of test_perf_branches_no_hw()
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025376