Skip to content

Conversation

@divyashreepathihalli
Copy link
Collaborator

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @divyashreepathihalli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the flax dependency version in both the standard and CUDA-specific JAX requirements files. This ensures we're using a more recent version of the flax library across our environments, which can bring performance improvements or bug fixes from the newer flax release.

Highlights

  • Dependency Update: The flax library dependency has been updated to version 0.11.0 or newer (flax>=0.11.0) in the project's requirement files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the flax dependency by specifying a minimum version. My feedback focuses on improving the long-term stability of the project's dependencies by suggesting a more restrictive version constraint for flax to prevent potential issues with future releases.

--find-links https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
jax[cuda12]==0.6.2
flax
flax>=0.11.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While pinning the minimum version of flax is a good step, using an open-ended greater-than-or-equal-to (>=) dependency can lead to future build failures if a new version of flax introduces breaking changes. To improve build reproducibility and prevent unexpected issues, it's better to specify a compatible release range.

Consider using a compatible release specifier like ~= which is used for tensorflow in this project, or adding an upper bound. For example: flax~=0.11.0 (allows versions >=0.11.0 and <0.12.0).

flax~=0.11.0

requirements.txt Outdated
# Note that we test against the latest JAX on GPU.
jax[cpu]==0.5.0
flax
flax>=0.11.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While pinning the minimum version of flax is a good step, using an open-ended greater-than-or-equal-to (>=) dependency can lead to future build failures if a new version of flax introduces breaking changes. To improve build reproducibility and prevent unexpected issues, it's better to specify a compatible release range.

Consider using a compatible release specifier like ~= which is used for tensorflow in this project, or adding an upper bound. For example: flax~=0.11.0 (allows versions >=0.11.0 and <0.12.0).

flax~=0.11.0

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.72%. Comparing base (4085046) to head (3e4d000).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21527   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         567      567           
  Lines       56264    56264           
  Branches     8797     8797           
=======================================
  Hits        46544    46544           
  Misses       7562     7562           
  Partials     2158     2158           
Flag Coverage Δ
keras 82.53% <ø> (ø)
keras-jax 63.93% <ø> (ø)
keras-numpy 58.40% <ø> (-0.01%) ⬇️
keras-openvino 34.56% <ø> (ø)
keras-tensorflow 64.35% <ø> (ø)
keras-torch 63.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 29, 2025
@divyashreepathihalli divyashreepathihalli merged commit 7bf852c into keras-team:master Jul 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run ready to pull Ready to be merged into the codebase size:XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants