-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Update flax #21527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flax #21527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @divyashreepathihalli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the flax dependency version in both the standard and CUDA-specific JAX requirements files. This ensures we're using a more recent version of the flax library across our environments, which can bring performance improvements or bug fixes from the newer flax release.
Highlights
- Dependency Update: The flax library dependency has been updated to version 0.11.0 or newer (flax>=0.11.0) in the project's requirement files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the flax dependency by specifying a minimum version. My feedback focuses on improving the long-term stability of the project's dependencies by suggesting a more restrictive version constraint for flax to prevent potential issues with future releases.
requirements-jax-cuda.txt
Outdated
| --find-links https://storage.googleapis.com/jax-releases/jax_cuda_releases.html | ||
| jax[cuda12]==0.6.2 | ||
| flax | ||
| flax>=0.11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While pinning the minimum version of flax is a good step, using an open-ended greater-than-or-equal-to (>=) dependency can lead to future build failures if a new version of flax introduces breaking changes. To improve build reproducibility and prevent unexpected issues, it's better to specify a compatible release range.
Consider using a compatible release specifier like ~= which is used for tensorflow in this project, or adding an upper bound. For example: flax~=0.11.0 (allows versions >=0.11.0 and <0.12.0).
flax~=0.11.0
requirements.txt
Outdated
| # Note that we test against the latest JAX on GPU. | ||
| jax[cpu]==0.5.0 | ||
| flax | ||
| flax>=0.11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While pinning the minimum version of flax is a good step, using an open-ended greater-than-or-equal-to (>=) dependency can lead to future build failures if a new version of flax introduces breaking changes. To improve build reproducibility and prevent unexpected issues, it's better to specify a compatible release range.
Consider using a compatible release specifier like ~= which is used for tensorflow in this project, or adding an upper bound. For example: flax~=0.11.0 (allows versions >=0.11.0 and <0.12.0).
flax~=0.11.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21527 +/- ##
=======================================
Coverage 82.72% 82.72%
=======================================
Files 567 567
Lines 56264 56264
Branches 8797 8797
=======================================
Hits 46544 46544
Misses 7562 7562
Partials 2158 2158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.