Draft: Skip models in model_builder #909
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Following #908 i have created this proof of concept.
It works, but i have no idea if that's something useful or not.
Let me know what you think and i can improve the implementation if you like.
model_build(hp)is called (that's normal behaviour)hpprovides a new functionhp.skip_model(message)that can be called if the user decide that the parametersSKIPPEDSKIPPEDstatus is not counted as anINVALIDmodel, so the model is skipped silentlyIt looks to work fine, but there is a lake. At start,
model_buildis called only for a a "discovery" phase. At this time the user code can callhp.skip_model(), which interrupt unexpectedly the processing. To fix that we just could flaghpwith adicovery_phaseduring this phase, soskip_modelcould just dry run.Exemple