Skip to content

Conversation

hertschuh
Copy link
Collaborator

@hertschuh hertschuh commented Oct 8, 2025

Using the runners.

  • Update description
  • Remove unneeded "names" in yml
  • Remove empty lines in yml
  • Remove jax[cpu] in requirements-tensorflow-tpu.txt and add late imports

@hertschuh hertschuh marked this pull request as draft October 8, 2025 00:42
Copy link

Summary of Changes

Hello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the foundational infrastructure required to enable comprehensive testing of Keras with both JAX and TensorFlow backends on Tensor Processing Units (TPUs). It establishes distinct build environments, including a specialized Dockerfile for JAX/TPU and dedicated dependency lists for both frameworks, ensuring all necessary TPU-related libraries are correctly installed for robust test execution.

Highlights

  • JAX TPU Test Environment: A new Dockerfile has been added to establish a dedicated testing environment for Keras using the JAX backend with TPU support. This includes Python 3.10, essential system packages, and configuration for the JAX backend.
  • JAX TPU Dependencies: A new requirements-jax-tpu.txt file has been introduced, specifying the necessary dependencies such as tensorflow-cpu, jax[tpu], and jax-tpu-embedding to facilitate JAX-based TPU testing.
  • TensorFlow TPU Dependencies: A new requirements-tensorflow-tpu.txt file has been added, outlining the specific tensorflow-tpu dependency required for TensorFlow-based TPU testing.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/actions.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Docker and requirements files for running JAX and TensorFlow tests on TPUs. My review has identified several critical issues that will cause the build and dependency installation to fail. In the Dockerfile, there's a syntax error. In the requirements files, non-existent versions of TensorFlow are specified. I have also provided some medium-severity suggestions for the Dockerfile to improve build performance and maintainability.

@hertschuh hertschuh force-pushed the tpu_tests branch 24 times, most recently from 3015f12 to 29ba11b Compare October 9, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant