Skip to content

[fix] updateVisDataUpdater early exit #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

igorDykhta
Copy link
Collaborator

  • exit early from updateVisDataUpdater, as it can be called without datasets, for example, from combined updaters.
  • add setLoadingIndicator task only if any datasets are being added.

@igorDykhta igorDykhta requested review from ilyabo and heshan0131 April 24, 2025 00:11
@igorDykhta igorDykhta merged commit a0d14b7 into master Apr 28, 2025
8 checks passed
@igorDykhta igorDykhta deleted the igr/add-data-to-map-fix branch April 28, 2025 23:51
felixerdy pushed a commit to felixerdy/kepler.gl that referenced this pull request May 9, 2025
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Felix Erdmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants