Skip to content

cleaner and more accurate solution #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2015
Merged

Conversation

rohanp
Copy link

@rohanp rohanp commented Jun 14, 2015

this is what i do instead of studying for my physics final ;_;

@patrickyevsukov
Copy link
Collaborator

Go study! Then please add a test file and I will merge your pull.

@patrickyevsukov
Copy link
Collaborator

Looks like all of the 99 bottles problem algorithms (with one exception) lack tests.

@kennyledet, @dalleng, @jcla1, @Yonaba should tests ever be optional? If so, I can update the README to reflect that.

@kennyledet
Copy link
Owner

@patrickyevsukov As I'm updating the site, I've had to work around the repo structure a bit to fix things up for automation consistency while doing my best to leave the repo unaffected (like normalizing to lowercase which is something I'm glad I've picked up and will definitely use in the future), so I've gotten pretty familiar with patterns in the files and structure.

A lot of people didn't include test files in the beginnings of the repo, less so when it started growing but some still missed them, and some people still are missing them in new pull requests, so I vote that it should be optional.

I am planning on making use of implementations that have tests, on the site, but my automation scripts should be able to reliably detect and mark whether or not they do, so it shouldn't be problematic to make it optional.

patrickyevsukov added a commit that referenced this pull request Jun 15, 2015
cleaner and more accurate solution
@patrickyevsukov patrickyevsukov merged commit 69f46a5 into kennyledet:master Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants