Skip to content

Conversation

@ssmusoke
Copy link

No description provided.

@Halama
Copy link
Member

Halama commented May 18, 2018

Hi Stephen,
thanks for contribution. The reason why MacOS line breaks were not enable is that current implementation of CSV read can't handle it. I've extended tests to demonstrate it https://github.com/keboola/php-csv/pull/31/files
https://travis-ci.org/keboola/php-csv/jobs/380590953

But it looks like there is a simple workaround which makes it passing https://travis-ci.org/keboola/php-csv/jobs/380590953
We'll release soon a new major version #27 so I think we can implement this there in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants