Refactor - split into Reader and Writer classes

README.md

@@ -7,26 +7,25 @@
 
 The library provides a simple reader and writer for CSV files according to [RFC4180](https://tools.ietf.org/html/rfc4180). 
 The library is licensed under the [MIT](https://github.com/keboola/php-csv/blob/master/LICENSE) license. The library provides 
-a single `CsvFile` class for both reading and writing CSV files. The class is designed to be **immutable** and minimalistic.
+classes `CsvReader` and `CsvWriter` for reading and writing CSV files. The classes are designed to be **immutable** 
+and minimalistic.
 
 ## Usage
 
 ### Read CSV
 
 ```php
-$csvFile = new Keboola\Csv\CsvFile(__DIR__ . '/_data/test-input.csv');
+$csvFile = new Keboola\Csv\CsvReader(__DIR__ . '/_data/test-input.csv');
 foreach($csvFile as $row) {
 	var_dump($row);
 }
 ```
 
 #### Skip lines
-Skip the first two lines:
+Skip the first line:
 
 ```php
-use Keboola\Csv\CsvFile;
-$filename = __DIR__ . '/_data/test-input.csv';
-$csvFile = new \Keboola\Csv\CsvFile($fileName, CsvFile::DEFAULT_DELIMITER, CsvFile::DEFAULT_ENCLOSURE, CsvFile::DEFAULT_ENCLOSURE, 2)
+$csvFile = new \Keboola\Csv\CsvFile($fileName, CsvFile::DEFAULT_DELIMITER, CsvFile::DEFAULT_ENCLOSURE, CsvFile::DEFAULT_ESCAPED_BY, 1)
 foreach($csvFile as $row) {
 	var_dump($row);
 }
@@ -36,15 +35,15 @@ foreach($csvFile as $row) {
 ### Write CSV
 
 ```php
-$csvFile = new Keboola\Csv\CsvFile(__DIR__ . '/_data/test-output.csv');
-$rows = array(
-	array(
+$csvFile = new Keboola\Csv\CsvWriter(__DIR__ . '/_data/test-output.csv');
+$rows = [
+	[
 		'col1', 'col2',
-	),
-	array(
+	],
+	[
 		'line without enclosure', 'second column',
-	),
-);
+	],
+];
 
 foreach ($rows as $row) {
 	$csvFile->writeRow($row);
@@ -69,5 +68,4 @@ composer require keboola/csv
 require 'vendor/autoload.php';
 ```
 
-
 Read more in [Composer documentation](http://getcomposer.org/doc/01-basic-usage.md)

src/AbstractCsvFile.php

@@ -0,0 +1,104 @@
+<?php
+
+namespace Keboola\Csv;
+
+class AbstractCsvFile
+{
+    const DEFAULT_DELIMITER = ',';
+    const DEFAULT_ENCLOSURE = '"';
+
+    /**
+     * @var string
+     */
+    protected $delimiter;
+
+    /**
+     * @var string
+     */
+    protected $enclosure;
+
+    /**
+     * @var string
+     */
+    protected $lineBreak;
+
+
+    /**
+     * @param string $delimiter
+     * @throws InvalidArgumentException
+     */
+    protected function setDelimiter($delimiter)
+    {
+        $this->validateDelimiter($delimiter);
+        $this->delimiter = $delimiter;
+    }
+
+    /**
+     * @param string $delimiter
+     * @throws InvalidArgumentException
+     */
+    protected function validateDelimiter($delimiter)
+    {
+        if (strlen($delimiter) > 1) {
+            throw new InvalidArgumentException(
+                "Delimiter must be a single character. \"$delimiter\" received",
+                Exception::INVALID_PARAM,
+                null,
+                Exception::INVALID_PARAM_STR
+            );
+        }
+
+        if (strlen($delimiter) == 0) {
+            throw new InvalidArgumentException(
+                "Delimiter cannot be empty.",
+                Exception::INVALID_PARAM,
+                null,
+                Exception::INVALID_PARAM_STR
+            );
+        }
+    }
+
+    /**
+     * @param string $enclosure
+     * @return $this
+     * @throws InvalidArgumentException
+     */
+    protected function setEnclosure($enclosure)
+    {
+        $this->validateEnclosure($enclosure);
+        $this->enclosure = $enclosure;
+        return $this;
+    }
+
+    /**
+     * @param string $enclosure
+     * @throws InvalidArgumentException
+     */
+    protected function validateEnclosure($enclosure)
+    {
+        if (strlen($enclosure) > 1) {
+            throw new InvalidArgumentException(
+                "Enclosure must be a single character. \"$enclosure\" received",
+                Exception::INVALID_PARAM,
+                null,
+                Exception::INVALID_PARAM_STR
+            );
+        }
+    }
+
+    /**
+     * @return string
+     */
+    public function getDelimiter()
+    {
+        return $this->delimiter;
+    }
+
+    /**
+     * @return string
+     */
+    public function getEnclosure()
+    {
+        return $this->enclosure;
+    }
+}